: Convert mibstats to use kmalloc_percpu
Changeset 1.879.9.7 from [email protected] contains:
Review line 853
Quoted 8 lines
(quoted diff) +1
-0@@ -765,6 +847,7 @@ #ifdef CONFIG_SYSCTL ipv6_sysctl_unregister(); #endif + cleanup_ipv6_mibs(); } module_exit(inet6_exit); #endif /* MODULE */
This does not work when cleanup_ipv6_mibs() is marked __exit, the fix below is needed to build a kernel with ipv6.
===== net/ipv6/af_inet6.c 1.18 vs edited =====
net/ipv6/af_inet6.c +1 -1
@@ -684,7 +684,7 @@ } -static void __exit cleanup_ipv6_mibs(void) +static void cleanup_ipv6_mibs (void ) {kfree_percpu (ipv6_statistics[0 ]);kfree_percpu (ipv6_statistics[1 ]);
Quoted 2 lines
This does not work when
cleanup_ipv6_mibs()is marked__exit, the fix below is needed to build a kernel with ipv6.
Yes, it should not have been marked __exit.
Thanks for the patch
Dave, Plase apply.
Thanks,
Kiran