ipt_REJECT shouldn't send replies for wrong udp csum
Subsystems (2)
PATCH 1/1 ipt_REJECT shouldn't send replies for wrong udp csum
Hi Dave!
This is another patch of the series of patches you will receive from me today.
Please apply to 2.4.x and 2.5.x, thanks.
Author: Patrick McHardy <[email protected]>ipt_REJECT sends unreachables in response to UDP packets with invalid checksums, thereby exposing the existance of a firewall (as described in phrack #60, "broken crc firewall spotting" (or something like this), www.phrack.com). The patch makes ipt_REJECT verify UDP checksums if set.
net/ipv4/netfilter/ipt_REJECT.c +16 -0
@@ -6,6 +6,8 @@#include <linux/module.h> #include <linux/skbuff.h> #include <linux/ip.h> +#include <linux/udp.h> +#include <linux/icmp.h> #include <net/icmp.h> #include <net/ip.h> #include <net/tcp.h>
@@ -157,6 +159,7 @@static void send_unreach (struct sk_buff *skb_in,int code) {struct iphdr *iph; +struct udphdr *udph;struct icmphdr *icmph;struct sk_buff *nskb;u32 saddr;
@@ -186,6 +189,19 @@if (iph->frag_off&htons (IP_OFFSET ))return ; +/* if UDP checksum is set, verify it's correct */ +if (iph->protocol ==IPPROTO_UDP + && skb_in->tail-(u8 *)iph >=sizeof (struct udphdr )) { +int datalen = skb_in->len - (iph->ihl<<2 ); + udph = (struct udphdr *)((char *)iph + (iph->ihl<<2 )); +if (udph->check + &&csum_tcpudp_magic (iph->saddr, iph->daddr, + datalen,IPPROTO_UDP , +csum_partial ((char *)udph, datalen, +0 )) !=0 ) +return ; + } +/* If we send an ICMP error to an ICMP error a mess would result.. */ if (iph->protocol ==IPPROTO_ICMP && skb_in->tail-(u8 *)iph >=sizeof (struct icmphdr )) {
Signature · 4 lines
- Harald Welte / [email protected] http://www.gnumonks.org/ ============================================================================ "If this were a dictatorship, it'd be a heck of a lot easier, just so long as I'm the dictator." -- George W. Bush Dec 18, 2000
David S. Miller
Applied From: Harald Welte <[email protected]>
Date: Thu, 9 Jan 2003 15:46:41 +0100
Author: Patrick McHardy <[email protected]>
ipt_REJECT sends unreachables in response to UDP packets with invalid checksums, thereby exposing the existance of a firewall (as described in phrack #60, "broken crc firewall spotting" (or something like this), www.phrack.com). The patch makes ipt_REJECT verify UDP checksums if set.
Applied, thanks.