don't create regular files in devfs
PATCH 1/1 don't create regular files in devfs
Even more devfs creptomancy :)
When devfs is enabled the i386 microcode and mtrr drivers try to create regular files in devfs in addition to their regular interfaces (miscdevice and procfs). The tools work with the normal interfaces anyway in non-devfs systems and regular files in _dev_fs are a rather strange concept..
Get rid of it.
arch/i386/kernel/microcode.c +1 -29
@@ -65,7 +65,6 @@#include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/miscdevice.h> -#include <linux/devfs_fs_kernel.h> #include <linux/spinlock.h> #include <linux/mm.h>
@@ -122,39 +121,14 @@ .fops = µcode_fops, }; -static devfs_handle_t devfs_handle; -static int __init microcode_init (void ) { -int error; - - error =misc_register (µcode_dev); -if (error) -printk (KERN_WARNING -"microcode: can't misc_register on minor=%d\n" , -MICROCODE_MINOR ); - - devfs_handle =devfs_register (NULL ,"cpu/microcode" , -DEVFS_FL_DEFAULT ,0 ,0 ,S_IFREG |S_IRUSR |S_IWUSR , - µcode_fops,NULL ); -if (devfs_handle ==NULL && error) { -printk (KERN_ERR "microcode: failed to devfs_register()\n" ); -misc_deregister (µcode_dev); - goto out; - } - error =0 ; -printk (KERN_INFO -"IA-32 Microcode Update Driver: v%s <[email protected]>\n" , -MICROCODE_VERSION ); - -out: -return error; +return misc_register (µcode_dev); } static void __exit microcode_exit(void) {misc_deregister (µcode_dev); -devfs_unregister (devfs_handle);if (mc_applied)kfree (mc_applied); printk(KERN_INFO "IA-32 Microcode Update Driver v%s unregistered\n",
@@ -373,7 +347,6 @@ ret = (ssize_t )len; } out_fsize: -devfs_set_file_size (devfs_handle, mc_fsize);vfree (microcode); out_unlock:up_write (µcode_rwsem);
@@ -389,7 +362,6 @@if (mc_applied) {int bytes =NR_CPUS *sizeof (struct microcode ); -devfs_set_file_size (devfs_handle,0 );kfree (mc_applied); mc_applied =NULL ;printk (KERN_INFO "microcode: freed %d bytes\n" , bytes);
arch/i386/kernel/cpu/mtrr/if.c +0 -9
@@ -1,6 +1,5 @@#include <linux/init.h> #include <linux/proc_fs.h> -#include <linux/devfs_fs_kernel.h> #include <linux/ctype.h> #include <linux/module.h> #include <linux/seq_file.h>
@@ -300,8 +299,6 @@# endif /* CONFIG_PROC_FS */ -static devfs_handle_t devfs_handle; -char *attrib_to_str (int x) {return (x <=6 ) ? mtrr_strings[x] :"?" ;
@@ -337,7 +334,6 @@ attrib_to_str(type), usage_table[i]); } } -devfs_set_file_size (devfs_handle, len);return 0 ; }
@@ -350,11 +346,6 @@ proc_root_mtrr->owner =THIS_MODULE ; proc_root_mtrr->proc_fops = &mtrr_fops; } -#endif -#ifdef USERSPACE_INTERFACE - devfs_handle =devfs_register (NULL ,"cpu/mtrr" ,DEVFS_FL_DEFAULT ,0 ,0 , -S_IFREG |S_IRUGO |S_IWUSR , - &mtrr_fops,NULL );#endif return 0 ; }
arch/i386/kernel/microcode.c line 148
Quoted 7 lines · Christoph Hellwig
Even more devfs creptomancy :)
Get rid of it.
arch/i386/kernel/microcode.c +0
-3-printk (KERN_INFO -"IA-32 Microcode Update Driver: v%s <[email protected]>\n" , -MICROCODE_VERSION );
Did you intend to nuke this too? Personally, I prefer having all the drivers tell me what they are....
Signature · 3 lines
Valdis Kletnieks Computer Systems Senior Engineer Virginia Tech