Kill SHOUTING in kernel/io_apic.c
Hi!
That source is shouting WAY TOO MUCH. Please apply,
Pavel
arch/i386/kernel/io_apic.c +6 -6
@@ -824,7 +824,7 @@enable_8259A_irq (0 ); } -void __init UNEXPECTED_IO_APIC (void ) +void __init unexpected_IO_APIC (void ) {printk (KERN_WARNING " WARNING: unexpected IO-APIC, please mail\n" );printk (KERN_WARNING " to [email protected]\n" );
@@ -865,7 +865,7 @@printk (KERN_DEBUG "....... : Delivery Type: %X\n" , reg_00.delivery_type);printk (KERN_DEBUG "....... : LTS : %X\n" , reg_00.LTS);if (reg_00.__reserved_0 || reg_00.__reserved_1 || reg_00.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG ".... register #01: %08X\n" , *(int *)®_01);printk (KERN_DEBUG "....... : max redirection entries: %04X\n" , reg_01.entries);
@@ -877,7 +877,7 @@ (reg_01.entries != 0x2E) && (reg_01.entries != 0x3F) ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG "....... : PRQ implemented: %X\n" , reg_01.PRQ);printk (KERN_DEBUG "....... : IO APIC version: %04X\n" , reg_01.version);
@@ -887,15 +887,15 @@ (reg_01.version != 0x13) && /* Xeon IO-APICs */ (reg_01.version != 0x20) /* Intel P64H (82806 AA) */ ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.__reserved_1 || reg_01.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.version >=0x10 ) {printk (KERN_DEBUG ".... register #02: %08X\n" , *(int *)®_02);printk (KERN_DEBUG "....... : arbitration: %02X\n" , reg_02.arbitration);if (reg_02.__reserved_1 || reg_02.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC (); }printk (KERN_DEBUG ".... IRQ redirection table:\n" );
Signature · 2 lines
Worst form of spam? Adding advertisment signatures ala sourceforge.net. What goes next? Inserting advertisment *into* email?
In message <[email protected]> you write:
Quoted 3 lines
Hi!
That source is shouting WAY TOO MUCH. Please apply,
Either you can make unexpected_IO_APIC static, or your patch missed a caller.
In fact, grep reveals the former. x86_64, too.
arch/i386/kernel/io_apic.c
Quoted 4 lines
Pavel
arch/i386/kernel/io_apic.c +0
-0
0100
arch/i386/kernel/io_apic.c line 865
Quoted 11 lines
arch/i386/kernel/io_apic.c +1
-1@@ -824,7 +824,7 @@enable_8259A_irq (0 ); } -void __init UNEXPECTED_IO_APIC (void ) +void __init unexpected_IO_APIC (void ) {printk (KERN_WARNING " WARNING: unexpected IO-APIC, please mail\n" );printk (KERN_WARNING " to [email protected]\n" );@@ -865,7 +865,7 @@ printk(KERN_DEBUG "....... : Delivery Type: %X\n", reg_00.delivery_t
ype);
arch/i386/kernel/io_apic.c
Quoted 7 lines
arch/i386/kernel/io_apic.c +1
-1printk (KERN_DEBUG "....... : LTS : %X\n" , reg_00.LTS);if (reg_00.__reserved_0 || reg_00.__reserved_1 || reg_00.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG ".... register #01: %08X\n" , *(int *)®_01); printk(KERN_DEBUG "....... : max redirection entries: %04X\n", reg_
01.entries);
arch/i386/kernel/io_apic.c line 883
Quoted 9 lines
arch/i386/kernel/io_apic.c +1
-1@@ -877,7 +877,7 @@ (reg_01.entries != 0x2E) && (reg_01.entries != 0x3F) ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG "....... : PRQ implemented: %X\n" , reg_01.PRQ); printk(KERN_DEBUG "....... : IO APIC version: %04X\n", reg_01.versi
on);
arch/i386/kernel/io_apic.c line 895
Quoted 12 lines
arch/i386/kernel/io_apic.c +2
-2@@ -887,15 +887,15 @@ (reg_01.version != 0x13) && /* Xeon IO-APICs */ (reg_01.version != 0x20) /* Intel P64H (82806 AA) */ ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.__reserved_1 || reg_01.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.version >=0x10 ) {printk (KERN_DEBUG ".... register #02: %08X\n" , *(int *)®_02)
;
arch/i386/kernel/io_apic.c line 896
Quoted 1 line
arch/i386/kernel/io_apic.c +0
-0printk(KERN_DEBUG "....... : arbitration: %02X\n", reg_02.a
rbitration);
Quoted 16 lines
arch/i386/kernel/io_apic.c +1
-1if (reg_02.__reserved_1 || reg_02.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC (); }printk (KERN_DEBUG ".... IRQ redirection table:\n" );Signature · 8 lines
-- Worst form of spam? Adding advertisment signatures ala sourceforge.net. What goes next? Inserting advertisment *into* email? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Hi!
Quoted 6 lines
Quoted 1 line
That source is shouting WAY TOO MUCH. Please apply,
Either you can make
unexpected_IO_APICstatic, or your patch missed a caller.In fact, grep reveals the former.
x86_64, too.
Here's updated patch. (I guess x86_64 will want to sync after linus applies that...)
arch/i386/kernel/io_apic.c +6 -6
@@ -824,7 +824,7 @@enable_8259A_irq (0 ); } -void __init UNEXPECTED_IO_APIC (void ) +static void __init unexpected_IO_APIC (void ) {printk (KERN_WARNING " WARNING: unexpected IO-APIC, please mail\n" );printk (KERN_WARNING " to [email protected]\n" );
@@ -865,7 +865,7 @@printk (KERN_DEBUG "....... : Delivery Type: %X\n" , reg_00.delivery_type);printk (KERN_DEBUG "....... : LTS : %X\n" , reg_00.LTS);if (reg_00.__reserved_0 || reg_00.__reserved_1 || reg_00.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG ".... register #01: %08X\n" , *(int *)®_01);printk (KERN_DEBUG "....... : max redirection entries: %04X\n" , reg_01.entries);
@@ -877,7 +877,7 @@ (reg_01.entries != 0x2E) && (reg_01.entries != 0x3F) ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();printk (KERN_DEBUG "....... : PRQ implemented: %X\n" , reg_01.PRQ);printk (KERN_DEBUG "....... : IO APIC version: %04X\n" , reg_01.version);
@@ -887,15 +887,15 @@ (reg_01.version != 0x13) && /* Xeon IO-APICs */ (reg_01.version != 0x20) /* Intel P64H (82806 AA) */ ) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.__reserved_1 || reg_01.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC ();if (reg_01.version >=0x10 ) {printk (KERN_DEBUG ".... register #02: %08X\n" , *(int *)®_02);printk (KERN_DEBUG "....... : arbitration: %02X\n" , reg_02.arbitration);if (reg_02.__reserved_1 || reg_02.__reserved_2) -UNEXPECTED_IO_APIC (); +unexpected_IO_APIC (); }printk (KERN_DEBUG ".... IRQ redirection table:\n" );
Signature · 2 lines
Casualities in World Trade Center: ~3k dead inside the building, cryptography in U.S.A. and free speech in Czech Republic.