Convert fs/nfsctl.c to use C99 named initiailzers
Subsystems (3)
PATCH 1/1 Convert fs/nfsctl.c to use C99 named initiailzers
Hi.
The following patch converts the file to use C99 named initializers. These change make the file compile with fewer warnings if '-W' is added to the compile flags, and may enhance code readability. Let me know if you think this should be sent to Linus.
Art Haas
===== fs/nfsctl.c 1.5 vs edited =====
fs/nfsctl.c +30 -7
@@ -54,13 +54,36 @@static struct {char *name;int wsize;int rsize; } map[] = { - [NFSCTL_SVC ]={".svc" ,sizeof (struct nfsctl_svc )}, - [NFSCTL_ADDCLIENT ]={".add" ,sizeof (struct nfsctl_client )}, - [NFSCTL_DELCLIENT ]={".del" ,sizeof (struct nfsctl_client )}, - [NFSCTL_EXPORT ]={".export" ,sizeof (struct nfsctl_export )}, - [NFSCTL_UNEXPORT ]={".unexport" ,sizeof (struct nfsctl_export )}, - [NFSCTL_GETFD ]={".getfd" ,sizeof (struct nfsctl_fdparm ),NFS_FHSIZE }, - [NFSCTL_GETFS ]={".getfs" ,sizeof (struct nfsctl_fsparm ),sizeof (struct knfsd_fh )}, + [NFSCTL_SVC ] = { + .name =".svc" , + .wsize =sizeof (struct nfsctl_svc ) + }, + [NFSCTL_ADDCLIENT ] = { + .name =".add" , + .wsize =sizeof (struct nfsctl_client ) + }, + [NFSCTL_DELCLIENT ] = { + .name =".del" , + .wsize =sizeof (struct nfsctl_client ) + }, + [NFSCTL_EXPORT ] = { + .name =".export" , + .wsize =sizeof (struct nfsctl_export ) + }, + [NFSCTL_UNEXPORT ] = { + .name =".unexport" , + .wsize =sizeof (struct nfsctl_export ) + }, + [NFSCTL_GETFD ] = { + .name =".getfd" , + .wsize =sizeof (struct nfsctl_fdparm ), + .rsize =NFS_FHSIZE + }, + [NFSCTL_GETFS ] = { + .name =".getfs" , + .wsize =sizeof (struct nfsctl_fsparm ), + .rsize =sizeof (struct knfsd_fh ) + }, };long
Signature · 3 lines
They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety. -- Benjamin Franklin, Historical Review of Pennsylvania, 1759