Skip to contentSkip to conversation

remove /proc/meminfo:MemShared

PATCH In review Marc-Christian Petersen 3 participants 4 messages Feb 19, 2003 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove /proc/meminfo:MemShared

Hi Marcelo,

it seems to have been displaying zero for the past several years.

Same as in 2.5, by AKPM.

See here:
http://linux.bkbits.net:8080/linux-2.5/[email protected]?nav=index.html|ChangeSet@-8w

ciao, Marc

fs/proc/proc_misc.c +0 -2
@@ -180,7 +180,6 @@ static int meminfo_read_proc(char *page,
 	len += sprintf(page+len,
 		"MemTotal:     %8lu kB\n"
 		"MemFree:      %8lu kB\n"
-		"MemShared:    %8lu kB\n"
 		"Buffers:      %8lu kB\n"
 		"Cached:       %8lu kB\n"
 		"SwapCached:   %8lu kB\n"
@@ -194,7 +193,6 @@ static int meminfo_read_proc(char *page,
 		"SwapFree:     %8lu kB\n",
 		K(i.totalram),
 		K(i.freeram),
-		K(i.sharedram),
 		K(i.bufferram),
 		K(pg_size - swapper_space.nrpages),
 		K(swapper_space.nrpages),
#1 lore raw
Quoted 1 line · Marc-Christian Petersen

Hi Marcelo,

Hi Marc,

Quoted 4 lines

it seems to have been displaying zero for the past several years.

Same as in 2.5, by AKPM.
...

I don't think it's good to do this change in a stable kernel series. The entry doesn't do any harm and there might be programs that parse /proc/meminfo and expect MemShared to be present.

Quoted 1 line

ciao, Marc

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw

On Wednesday 19 February 2003 14:00, Adrian Bunk wrote:

Hi Adrian,

Quoted 3 lines

I don't think it's good to do this change in a stable kernel series. The entry doesn't do any harm and there might be programs that parse /proc/meminfo and expect MemShared to be present.

well, I am not aware of any program that needs MemShared.

This is also in my WOLK tree for a long time (even longer than it was in 2.5) and no one out there complained about it yet :)

ciao, Marc

#3 lore raw
In reply to Marc-Christian Petersen
Quoted 3 lines · Marc-Christian Petersen

Hi Marcelo,

it seems to have been displaying zero for the past several years.

It was left in because some tools break if you remove it. For 2.5 its much less of an issue.