Keyspan USB/Serial Drivers for 2.4.20/2.4.21-pre4
Subsystems (2)
Hello List,
I'm not sure why, but the current kernel source tree doesn't support some
of the Keyspan USB/Serial adapter products (49WLC and MPR). There is code
at: http://www.keyspan.com/support/linux/files/currentversion/rev2003jan31/
but it only works with 2.4.18 or 2.4.19. Keyspan seems to think the code is current and they didn't want my patches. Here they are for posterity.
Note: I did not include the firmware header files in the patch. They can be obtained at the URL above.
Best regards,
Jeffrey S. Laing
[email protected]
drivers/usb/serial/Config.in +23 -22
@@ -6,36 +6,37 @@ dep_tristate 'USB Serial Converter support' CONFIG_USB_SERIAL $CONFIG_USB if [ "$CONFIG_USB_SERIAL" != "n" ]; then - dep_bool ' USB Serial Converter verbose debug' CONFIG_USB_SERIAL_DEBUG $CONFIG_USB_SERIAL + dep_mbool ' USB Serial Converter verbose debug' CONFIG_USB_SERIAL_DEBUG $CONFIG_USB_SERIAL dep_mbool ' USB Generic Serial Driver' CONFIG_USB_SERIAL_GENERIC $CONFIG_USB_SERIAL - dep_tristate ' USB Belkin and Peracom Single Port Serial Driver' CONFIG_USB_SERIAL_BELKIN $CONFIG_USB_SERIAL - dep_tristate ' USB ConnectTech WhiteHEAT Serial Driver' CONFIG_USB_SERIAL_WHITEHEAT $CONFIG_USB_SERIAL + dep_tristate ' USB Belkin and Peracom Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_BELKIN $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL + dep_tristate ' USB ConnectTech WhiteHEAT Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_WHITEHEAT $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB Digi International AccelePort USB Serial Driver' CONFIG_USB_SERIAL_DIGI_ACCELEPORT $CONFIG_USB_SERIAL - dep_tristate ' USB Empeg empeg-car Mark I/II Driver' CONFIG_USB_SERIAL_EMPEG $CONFIG_USB_SERIAL - dep_tristate ' USB FTDI Single Port Serial Driver' CONFIG_USB_SERIAL_FTDI_SIO $CONFIG_USB_SERIAL + dep_tristate ' USB Empeg empeg-car Mark I/II Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_EMPEG $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL + dep_tristate ' USB FTDI Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_FTDI_SIO $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB Handspring Visor / Palm m50x / Sony Clie Driver' CONFIG_USB_SERIAL_VISOR $CONFIG_USB_SERIAL - dep_tristate ' USB Compaq iPAQ / HP Jornada / Casio EM500 Driver' CONFIG_USB_SERIAL_IPAQ $CONFIG_USB_SERIAL + dep_tristate ' USB Compaq iPAQ Driver' CONFIG_USB_SERIAL_IPAQ $CONFIG_USB_SERIAL dep_tristate ' USB IR Dongle Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_IR $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL - dep_tristate ' USB Inside Out Edgeport Serial Driver' CONFIG_USB_SERIAL_EDGEPORT $CONFIG_USB_SERIAL - dep_tristate ' USB Inside Out Edgeport Serial Driver (TI devices)' CONFIG_USB_SERIAL_EDGEPORT_TI $CONFIG_USB_SERIAL + dep_tristate ' USB Inside Out Edgeport Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_EDGEPORT $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB Keyspan PDA Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_KEYSPAN_PDA $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL - dep_tristate ' USB Keyspan USA-xxx Serial Driver' CONFIG_USB_SERIAL_KEYSPAN $CONFIG_USB_SERIAL + dep_tristate ' USB Keyspan USA-xxx Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_KEYSPAN $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL if [ "$CONFIG_USB_SERIAL_KEYSPAN" != "n" ]; then - bool ' USB Keyspan USA-28 Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28 - bool ' USB Keyspan USA-28X Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28X - bool ' USB Keyspan USA-28XA Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28XA - bool ' USB Keyspan USA-28XB Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28XB - bool ' USB Keyspan USA-19 Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19 - bool ' USB Keyspan USA-18X Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA18X - bool ' USB Keyspan USA-19W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19W - bool ' USB Keyspan USA-19QW Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QW - bool ' USB Keyspan USA-19QI Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QI - bool ' USB Keyspan USA-49W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA49W + bool ' USB Keyspan USA-28 Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28 $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-28X Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28X $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-28XA Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28XA $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-28XB Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA28XB $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-19 Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19 $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-19QI Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QI $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-18X Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA18X $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-19W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19W $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-19QW Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QW $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan MPR Firmware' CONFIG_USB_SERIAL_KEYSPAN_MPR $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-49W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA49W $CONFIG_USB_SERIAL_KEYSPAN + bool ' USB Keyspan USA-49WLC Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA49WLC $CONFIG_USB_SERIAL_KEYSPAN fi - dep_tristate ' USB MCT Single Port Serial Driver' CONFIG_USB_SERIAL_MCT_U232 $CONFIG_USB_SERIAL - dep_tristate ' USB KL5KUSB105 (Palmconnect) Driver' CONFIG_USB_SERIAL_KLSI $CONFIG_USB_SERIAL + dep_tristate ' USB MCT Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_MCT_U232 $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL + dep_tristate ' USB KL5KUSB105 (Palmconnect) Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_KLSI $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB KOBIL chipcard reader (EXPERIMENTAL)' CONFIG_USB_SERIAL_KOBIL_SCT $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL - dep_tristate ' USB Prolific 2303 Single Port Serial Driver' CONFIG_USB_SERIAL_PL2303 $CONFIG_USB_SERIAL + dep_tristate ' USB Prolific 2303 Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_PL2303 $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB REINER SCT cyberJack pinpad/e-com chipcard reader (EXPERIMENTAL)' CONFIG_USB_SERIAL_CYBERJACK $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB Xircom / Entregra Single Port Serial Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_XIRCOM $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL dep_tristate ' USB ZyXEL omni.net LCD Plus Driver (EXPERIMENTAL)' CONFIG_USB_SERIAL_OMNINET $CONFIG_USB_SERIAL $CONFIG_EXPERIMENTAL
drivers/usb/serial/keyspan.c +34 -3
@@ -28,6 +28,22 @@ Change History + Wed Feb 19 22:00:00 PST 2003 (Jeffrey S. Laing <[email protected]>) + Merged the current (1/31/03) Keyspan code with the current (2.4.21-pre4) + Linux source tree. The Linux tree lacked support for the 49WLC and + others. The Keyspan patches didn't work with the current kernel. + + Wed Apr 25 12:00:00 PST 2002 (Keyspan) + Started with Hugh Blemings' code dated Jan 17, 2002. All adapters + now supported (including QI and QW). Modified port open, port + close, and send setup() logic to fix various data and endpoint + synchronization bugs and device LED status bugs. Changed keyspan_ + write_room() to accurately return transmit buffer availability. + Changed forwardingLength from 1 to 16 for all adapters. + + Fri Oct 12 16:45:00 EST 2001 + Preliminary USA-19QI and USA-28 support (both test OK for me, YMMV) + Wed Apr 25 12:00:00 PST 2002 (Keyspan) Started with Hugh Blemings' code dated Jan 17, 2002. All adapters now supported (including QI and QW). Modified port open, port
@@ -71,6 +87,8 @@Sat Jul 8 11:11:48 EST 2000 Hugh First public release - nothing works except the firmware upload. Tested on PPC and x86 architectures, seems to behave... + +2003jan30 LPM add support for the 49WLC and MPR */
@@ -102,7 +120,7 @@/* * Version Information */ -#define DRIVER_VERSION "v1.1.3" +#define DRIVER_VERSION "v1.1.4"#define DRIVER_AUTHOR "Hugh Blemings <[email protected]"#define DRIVER_DESC "Keyspan USB to Serial Converter Driver"
@@ -188,7 +207,7 @@return 0 ; } -static void __exit keyspan_exit (void) +void __exit keyspan_exit (void) {usb_serial_deregister (&keyspan_pre_device);usb_serial_deregister (&keyspan_1port_device);
@@ -904,6 +922,9 @@/* usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe), usb_pipeout(urb->pipe), 0); */ } +// if the device is a USA49x, determine whether it is an W or WLC model +// and set the baud clock accordingly +keyspan_send_setup (port,1 );//mdelay(100); keyspan_set_termios (port,NULL );
@@ -1012,6 +1034,11 @@ fw_name ="USA19QI" ;break ; +case keyspan_mpr_pre_product_id: + record = &keyspan_mpr_firmware[0 ]; + fw_name ="MPR" ; +break ; +case keyspan_usa19qw_pre_product_id: record = &keyspan_usa19qw_firmware[0 ]; fw_name ="USA19QI" ;
@@ -1032,6 +1059,11 @@ fw_name ="USA49W" ;break ; +case keyspan_usa49wlc_pre_product_id: + record = &keyspan_usa49wlc_firmware[0 ]; + fw_name ="USA49WLC" ; +break ; +default : record =NULL ; fw_name ="Unknown" ;
@@ -1322,7 +1355,7 @@ div,/* divisor */ cnt;/* inverse of divisor (programmed into 8051) */ -dbg ("%s - %d." , __FUNCTION__, baud_rate); +dbg (__FUNCTION__" %d.\n" , baud_rate);/* prevent divide by zero */ if ((b16 = baud_rate *16L ) ==0 )
drivers/usb/serial/keyspan.h +42 -0
139 lines not on this page · raw message
Quoted 7 lines · System Administrator
Hello List,
I'm not sure why, but the current kernel source tree doesn't support some
of the Keyspan USB/Serial adapter products (49WLC and MPR). There is code
at: http://www.keyspan.com/support/linux/files/currentversion/rev2003jan31/
but it only works with 2.4.18 or 2.4.19. Keyspan seems to think the code is current and they didn't want my patches. Here they are for posterity.
Any reason you didn't send this to the listed maintainer for these drivers? :)
Thanks for doing this, but why did you modify the Config.in file so much? That's not correct.
And does this patch work with the new devices?
thanks,
greg k-h
Quoted 13 lines · System Administrator
Quoted 7 lines
Hello List,
I'm not sure why, but the current kernel source tree doesn't support some
of the Keyspan USB/Serial adapter products (49WLC and MPR). There is code
at: http://www.keyspan.com/support/linux/files/currentversion/rev2003jan31/
but it only works with 2.4.18 or 2.4.19. Keyspan seems to think the code is current and they didn't want my patches. Here they are for posterity.Any reason you didn't send this to the listed maintainer for these drivers? :)
Quoted 8 lines
Thanks for doing this, but why did you modify the Config.in file so much? That's not correct.
And does this patch work with the new devices?
thanks,
greg k-h
Please excuse my mistakes. That was my very first post to the list even though I've been reading it for many years. I wasn't entirely sure how to get this out there. I'm glad you noticed it Greg :)
You're right. the Config.in file didn't need all those changes. I mistakedly diffed against the wrong file.
The 49WLC device works fine with this patch. I have not tested the MPR but it should work too.
Below is a better patch.
Jeff
drivers/usb/serial/Config.in +2 -0
@@ -30,7 +30,9 @@ bool ' USB Keyspan USA-19W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19W bool ' USB Keyspan USA-19QW Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QW bool ' USB Keyspan USA-19QI Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA19QI + bool ' USB Keyspan MPR Firmware' CONFIG_USB_SERIAL_KEYSPAN_MPR bool ' USB Keyspan USA-49W Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA49W + bool ' USB Keyspan USA-49WLC Firmware' CONFIG_USB_SERIAL_KEYSPAN_USA49WLC fi dep_tristate ' USB MCT Single Port Serial Driver' CONFIG_USB_SERIAL_MCT_U232 $CONFIG_USB_SERIAL dep_tristate ' USB KL5KUSB105 (Palmconnect) Driver' CONFIG_USB_SERIAL_KLSI $CONFIG_USB_SERIAL
drivers/usb/serial/keyspan.c +33 -2
@@ -28,6 +28,24 @@ Change History + Wed Feb 19 22:00:00 PST 2003 (Jeffrey S. Laing <[email protected]>) + Merged the current (1/31/03) Keyspan code with the current (2.4.21-pre4) + Linux source tree. The Linux tree lacked support for the 49WLC and + others. The Keyspan patches didn't work with the current kernel. + + 2003jan30 LPM add support for the 49WLC and MPR + + Wed Apr 25 12:00:00 PST 2002 (Keyspan) + Started with Hugh Blemings' code dated Jan 17, 2002. All adapters + now supported (including QI and QW). Modified port open, port + close, and send setup() logic to fix various data and endpoint + synchronization bugs and device LED status bugs. Changed keyspan_ + write_room() to accurately return transmit buffer availability. + Changed forwardingLength from 1 to 16 for all adapters. + + Fri Oct 12 16:45:00 EST 2001 + Preliminary USA-19QI and USA-28 support (both test OK for me, YMMV) + Wed Apr 25 12:00:00 PST 2002 (Keyspan) Started with Hugh Blemings' code dated Jan 17, 2002. All adapters now supported (including QI and QW). Modified port open, port
@@ -102,7 +120,7 @@/* * Version Information */ -#define DRIVER_VERSION "v1.1.3" +#define DRIVER_VERSION "v1.1.4"#define DRIVER_AUTHOR "Hugh Blemings <[email protected]"#define DRIVER_DESC "Keyspan USB to Serial Converter Driver"
@@ -904,6 +922,9 @@/* usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe), usb_pipeout(urb->pipe), 0); */ } +// if the device is a USA49x, determine whether it is an W or WLC model +// and set the baud clock accordingly +keyspan_send_setup (port,1 );//mdelay(100); keyspan_set_termios (port,NULL );
@@ -1012,6 +1034,11 @@ fw_name ="USA19QI" ;break ; +case keyspan_mpr_pre_product_id: + record = &keyspan_mpr_firmware[0 ]; + fw_name ="MPR" ; +break ; +case keyspan_usa19qw_pre_product_id: record = &keyspan_usa19qw_firmware[0 ]; fw_name ="USA19QI" ;
@@ -1032,6 +1059,11 @@ fw_name ="USA49W" ;break ; +case keyspan_usa49wlc_pre_product_id: + record = &keyspan_usa49wlc_firmware[0 ]; + fw_name ="USA49WLC" ; +break ; +default : record =NULL ; fw_name ="Unknown" ;
@@ -1322,7 +1355,7 @@ div,/* divisor */ cnt;/* inverse of divisor (programmed into 8051) */ -dbg ("%s - %d." , __FUNCTION__, baud_rate); +dbg (__FUNCTION__" %d.\n" , baud_rate);/* prevent divide by zero */ if ((b16 = baud_rate *16L ) ==0 )
drivers/usb/serial/keyspan.h +42 -0
139 lines not on this page · raw message
Quoted 5 lines · System Administrator
Please excuse my mistakes. That was my very first post to the list even though I've been reading it for many years. I wasn't entirely sure how to get this out there. I'm glad you noticed it Greg :)
Quoted 7 lines
You're right. the Config.in file didn't need all those changes. I mistakedly diffed against the wrong file.
The 49WLC device works fine with this patch. I have not tested the MPR but it should work too.
Below is a better patch.
Thanks, I've applied this patch (and the firmware files) to my 2.4 and 2.5 trees, and will be sending them onward soon.
greg k-h