typhoon rx_copybreak
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · David Dillow
Done. Pushed to
bk://typhoon.bkbits.net/typhoon-2.4
bk://typhoon.bkbits.net/typhoon-2.5
I hope you don't mind my CC'ing lkml. I think may be useful information for others, as well.
For submitting net driver changes via BK, I would request what I request of others using BK (and what Marcelo requests of me):
Send me a separate email with an easily noticable subject, something like "[BK] typhoon net driver fixes/updates/whatever", including the output of Documentation/BK-usage/bk-make-sum. Typically this is done like
cd typhoon-2.4 bk-make-sum ../linux-vanilla-2.4 vi /tmp/linus.txt (fix URL, or whatever) email /tmp/linus.txt to me
then, additional email the broken-out GNU diffs for review. Here is an example, though there are several other ways to do this:
cd typhoon-2.4 bk changes -L ../linux-vanilla-2.4 2>&1 | \ perl csets-to-patches.pl # edit /tmp/rev-*.patch, and email, one per email
bk-make-sum and csets-to-patches are shipped in Documentation/BK-usage in both 2.4.x and 2.5.x.
And, unless the 2.4 and 2.5 patches are 100.0000% the same, send patches for both 2.4 and 2.5.
This spams me with a lot of email, but really does optimize the submission process, and gets your updates into the mainline kernel very quickly. Ideally, I just have to do "read, read, read, cut-n-paste your supplied bk pull URL"
Thanks and regards,
Jeff
P.S. Nice work on the driver. Even if technical issues are found, it's very clean and easy to review and debug.
Quoted 4 lines · Jeff Garzik
This spams me with a lot of email, but really does optimize the submission process, and gets your updates into the mainline kernel very quickly. Ideally, I just have to do "read, read, read, cut-n-paste your supplied bk pull URL"
Adding to this,
If you have a number of patches, I don't mind receiving a tarball of patches, instead of a bunch of separate emails. Up to you.
Jeff