Skip to contentSkip to conversation

[2.5] add missing global_flush_tlb() after change_page_attr() calls

PATCH In review Thomas Schlichter 2 participants 2 messages Feb 26, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [2.5] add missing global_flush_tlb() after change_page_attr() calls

After calling change_page_attr() global_flush_tlb() has to be called to kfree() some structures and make the changed page attributes visible by flushing the relevant TLB entries.

This is not done in some places and this patch should fix it...

Thomas Schlichter

P.S.: I sent this patch on friday yet, but I think friday is a bad day for sending patches... ;-)

arch/i386/mm/ioremap.c renamed from arch/i386/mm/ioremap.c.orig +2 -0
@@ -205,6 +205,7 @@
 			iounmap(p); 
 			p = NULL;
 		}
+		global_flush_tlb();
 	} 
 
 	return p;					
@@ -226,6 +227,7 @@
 		change_page_attr(virt_to_page(__va(p->phys_addr)),
 				 p->size >> PAGE_SHIFT,
 				 PAGE_KERNEL); 				 
+		global_flush_tlb();
 	} 
 	kfree(p); 
 }
arch/x86_64/mm/ioremap.c renamed from arch/x86_64/mm/ioremap.c.orig +2 -0
@@ -205,6 +205,7 @@
 			iounmap(p); 
 			p = NULL;
 		}
+		global_flush_tlb();
 	} 
 
 	return p;					
@@ -226,6 +227,7 @@
 		change_page_attr(virt_to_page(__va(p->phys_addr)),
 				 p->size >> PAGE_SHIFT,
 				 PAGE_KERNEL); 				 
+		global_flush_tlb();
 	} 
 	kfree(p); 
 }
arch/x86_64/kernel/pci-gart.c renamed from arch/x86_64/kernel/pci-gart.c.orig +1 -0
@@ -437,6 +437,7 @@
 	}
 	flush_gart(); 
 	
+	global_flush_tlb();
 		
 	printk("PCI-DMA: aperture base @ %x size %u KB\n", aper_base, aper_size>>10); 
 	return 0;
#1 lore raw
Quoted 4 lines · Thomas Schlichter

P.S.: I sent this patch on friday yet, but I think friday is a bad day for sending patches... ;-)

Your patch was merged on Monday :)