Skip to contentSkip to conversation

USB speedtouch: don't race the tasklets

PATCH Applied Duncan Sands 2 participants 2 messages Feb 28, 2003 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB speedtouch: don't race the tasklets

 speedtouch.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/misc/speedtouch.c +2 -2
diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
@@ -326,10 +326,10 @@
 
 	dbg ("udsl_complete_receive entered (urb 0x%p, status %d)", urb, urb->status);
 
-	tasklet_schedule (&instance->receive_tasklet);
 	/* may not be in_interrupt() */
 	spin_lock_irqsave (&instance->completed_receivers_lock, flags);
 	list_add_tail (&rcv->list, &instance->completed_receivers);
+	tasklet_schedule (&instance->receive_tasklet);
 	spin_unlock_irqrestore (&instance->completed_receivers_lock, flags);
 }
 
@@ -489,11 +489,11 @@
 
 	dbg ("udsl_complete_send entered (urb 0x%p, status %d)", urb, urb->status);
 
-	tasklet_schedule (&instance->send_tasklet);
 	/* may not be in_interrupt() */
 	spin_lock_irqsave (&instance->send_lock, flags);
 	list_add (&snd->list, &instance->spare_senders);
 	list_add (&snd->buffer->list, &instance->spare_buffers);
+	tasklet_schedule (&instance->send_tasklet);
 	spin_unlock_irqrestore (&instance->send_lock, flags);
 }
 
Applied
#1 lore raw
Quoted 2 lines · Duncan Sands
 speedtouch.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

greg k-h