Skip to contentSkip to conversation

fix undefined reference for sis drm.

PATCH In review Geoffrey Lee 2 participants 3 messages Mar 6, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix undefined reference for sis drm.

Hi all,

This fixes a bug where where if sis fb is not set and sis drm is selected then there will be undefined references to sis_malloc() and sis_free().

What I've done is a sort of a bandaid because I don't have hardware to fix and test.

	-- G.
Signature · 3 lines
char p[] = "\xeb\x1f\x5e\x89\x76\x08\x31\xc0\x88\x46\x07\x89\x46\x0c\xb0\x0b"
  "\x89\xf3\x8d\x4e\x08\x8d\x56\x0c\xcd\x80\x31\xdb\x89\xd8\x40\xcd"
  "\x80\xe8\xdc\xff\xff\xff/bin/sh";
drivers/char/drm/Config.in renamed from drivers/char/drm/Config.in.orig +3 -1
@@ -13,4 +13,6 @@
 dep_mbool    '    Enabled XFree 4.1 ioctl interface by default' CONFIG_DRM_I810_XFREE_41 $CONFIG_DRM_I810
 dep_tristate '  Intel 830M' CONFIG_DRM_I830 $CONFIG_AGP
 dep_tristate '  Matrox g200/g400' CONFIG_DRM_MGA $CONFIG_AGP
-dep_tristate '  SiS' CONFIG_DRM_SIS $CONFIG_AGP
+if [ "$CONFIG_FB_SIS" = "y" ]; then
+   dep_tristate '  SiS' CONFIG_DRM_SIS $CONFIG_AGP
+fi
Documentation/Configure.help renamed from Documentation/Configure.help.orig +3 -0
@@ -26277,6 +26277,9 @@
   Choose this option if you have a SIS graphics card. AGP support is
   required for this driver to work.
 
+  You will also be required to have support for SIS frame buffer as
+  it requires a few routines from it.
+
 Etrax Ethernet slave support (over lp0/1)
 CONFIG_ETRAX_ETHERNET_LPSLAVE
   This option enables a slave ETRAX 100 or ETRAX 100LX, connected to a
#1 lore raw
Quoted 9 lines · Geoffrey Lee

Hi all,

This fixes a bug where where if sis fb is not set and sis drm is selected then there will be undefined references to sis_malloc() and sis_free().

What I've done is a sort of a bandaid because I don't have hardware to fix and test.

Direct render occurs before the frame buffer so it doesn't work In addition you can have both modular so you'd want to make it

dep_tristate ' SiS' CONFIG_DRM_SIS $CONFIG_AGP $CONFIG_FB_SIS

even if the order worked out.

#2 lore raw
Quoted 7 lines

Direct render occurs before the frame buffer so it doesn't work In addition you can have both modular so you'd want to make it

dep_tristate ' SiS' CONFIG_DRM_SIS $CONFIG_AGP $CONFIG_FB_SIS

even if the order worked out.

Hm, yes indeed. Please apply the correct fix to your tree.

Sorry about the botched fix.

	-- G.
Signature · 3 lines
char p[] = "\xeb\x1f\x5e\x89\x76\x08\x31\xc0\x88\x46\x07\x89\x46\x0c\xb0\x0b"
  "\x89\xf3\x8d\x4e\x08\x8d\x56\x0c\xcd\x80\x31\xdb\x89\xd8\x40\xcd"
  "\x80\xe8\xdc\xff\xff\xff/bin/sh";