Skip to contentSkip to conversation

[2.5] memleak in drivers/char/vt.c

PATCH Oleg Drokin 1 participant 1 message Mar 7, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

Hello!

Seems there is a memleak on error exit path in drivers/char/vt.c in current bk, here's the patch. Found with help of smatch + enhanced unfree script.

===== drivers/char/vt.c 1.34 vs edited =====

drivers/char/vt.c +3 -1
@@ -747,8 +747,10 @@
 	screenbuf_size = new_screen_size;
 
 	err = resize_screen(currcons, new_cols, new_rows);
-	if (err)
+	if (err) {
+		kfree(newscreen);
 		return err;
+	}
 
 	rlth = min(old_row_size, new_row_size);
 	rrem = new_row_size - rlth;

Bye,
Oleg