Skip to contentSkip to conversation

Memleak in e100 driver

PATCH Oleg Drokin 1 participant 1 message Mar 12, 2003 Network drivers

lore
Share & tools
lore
#0 lore raw

Hello!

There is a memleak in e100 driver from intel, both in 2.4 and 2.5 e100_ethtool_gstrings does not free "strings" variable if it cannot copy it to userspace.
See the patch (identical for both 2.4 and 2.5).
Found with help of smatch + enhanced unfree script.

Bye,
Oleg

===== drivers/net/e100/e100_main.c 1.23 vs edited =====

drivers/net/e100/e100_main.c +6 -2
@@ -3824,11 +3824,15 @@
 		return -EOPNOTSUPP;
 	}
 
-	if (copy_to_user(ifr->ifr_data, &info, sizeof (info)))
+	if (copy_to_user(ifr->ifr_data, &info, sizeof (info))) {
+		kfree(strings);
 		return -EFAULT;
+	}
 
-	if (copy_to_user(usr_strings, strings, info.len * ETH_GSTRING_LEN))
+	if (copy_to_user(usr_strings, strings, info.len * ETH_GSTRING_LEN)) {
+		kfree(strings);
 		return -EFAULT;
+	}
 
 	kfree(strings);
 	return 0;