Skip to contentSkip to conversation

Memleak in Internet PhoneJACK driver

PATCH Oleg Drokin 1 participant 1 message Mar 13, 2003

lore
Share & tools
lore
#0 lore raw

Hello!

There is unfree memory on error return path in ixj_build_filter_cadence(). Trivial patch that applies to both 2.4 and 2.5 is below.
Found with help of smatch + enhanced ufree patch.

Bye,
Oleg

===== drivers/telephony/ixj.c 1.16 vs edited =====

drivers/telephony/ixj.c +2 -0
@@ -6001,12 +6001,14 @@
 		if(ixjdebug & 0x0001) {
 			printk(KERN_INFO "Could not copy cadence to kernel\n");
 		}
+		kfree(lcp);
 		return -EFAULT;
 	}
 	if (lcp->filter > 5) {
 		if(ixjdebug & 0x0001) {
 			printk(KERN_INFO "Cadence out of range\n");
 		}
+		kfree(lcp);
 		return -1;
 	}
 	j->cadence_f[lcp->filter].state = 0;