sleeping function called from illegal context at mm/slab.c:1723
Subsystems (2)
Every second I get following Debug message with kernel 2.5.66:
Debug: sleeping function called from illegal context at mm/slab.c:1723
Call Trace: [<c0124ba2>] __might_sleep+0x52/0x60 [<c014f4bd>] kmalloc+0x5d/0x16c [<c027ab6c>] accel_cursor+0xcc/0x2c0 [<c0121fb8>] try_to_wake_up+0x23c/0x3b4 [<c027af20>] fb_vbl_handler+0x74/0x8c [<c012281f>] scheduler_tick+0x37b/0x384 [<c01290ca>] profile_hook+0x1e/0x39 [<c011c7be>] smp_local_timer_interrupt+0xe/0xa0 [<c027980f>] cursor_timer_handler+0xf/0x28 [<c0130ea6>] run_timer_softirq+0x1ca/0x2cc [<c0279800>] cursor_timer_handler+0x0/0x28 [<c012c942>] do_softirq+0x52/0xac [<c010d468>] do_IRQ+0x2cc/0x2e4 [<c010b958>] common_interrupt+0x18/0x20
This message was not present with 2.5.65. I am using the VESA VGA frame buffer as following part of the boot.msg shows:
<6>vesafb: framebuffer at 0xe0000000, mapped to 0xd0800000, size 65536k <6>vesafb: mode is 1024x768x16, linelength=2048, pages=0 <6>vesafb: protected mode interface info at c000:c2c0 <6>vesafb: scrolling: redraw
<6>vesafb: directcolor: size=0:5:6:5, shift=0:11:5:0
<6>fb0: VESA VGA frame buffer device
My .config file is attached.
Thomas Schlichter
Quoted 4 lines · Thomas Schlichter
Every second I get following Debug message with kernel 2.5.66:
Debug: sleeping function called from illegal context at
mm/slab.c:1723Call Trace:
Yes. This is a known bug in the frame buffer driver. James Simmons is working on a fix for this.
regards,
dan carpenter
Quoted 9 lines · Thomas Schlichter
Quoted 4 lines
Every second I get following Debug message with kernel 2.5.66:
Debug: sleeping function called from illegal context at
mm/slab.c:1723Call Trace:Yes. This is a known bug in the frame buffer driver. James Simmons is working on a fix for this.
Try this and let me know how it works out for you.
drivers/video/console/fbcon.c +55 -30
@@ -172,8 +172,9 @@* Internal routines */ static void fbcon_set_display (struct vc_data *vc,int init,int logo); +static void accel_cursor (struct vc_data *vc,struct fb_info *info, +struct fb_cursor *cursor,int yy);static __inline__int real_y (struct display *p,int ypos); -static void fb_vbl_handler (int irq,void *dummy,struct pt_regs *fp);static __inline__void updatescrollmode (struct display *p,struct vc_data *vc);static __inline__void ywrap_up (struct vc_data *vc,int count);static __inline__void ywrap_down (struct vc_data *vc,int count);
@@ -194,6 +195,34 @@ }#endif +static void fb_callback (void *private) +{ +struct fb_info *info = (struct fb_info *) private; +struct display *p = &fb_display[fg_console]; +struct vc_data *vc = vc_cons[fg_console].d; +struct fb_cursor cursor; + +if (!info || !cursor_on) +return ; + +if (vbl_cursor_cnt && --vbl_cursor_cnt ==0 ) { + cursor.set =0 ; + +if (!cursor_drawn) + cursor.set =FB_CUR_SETCUR ; +accel_cursor (vc, info, &cursor,real_y (p, vc->vc_y)); + cursor_drawn ^=1 ; + vbl_cursor_cnt = cursor_blink_rate; + } +} + +static void fb_vbl_handler (int irq,void *dev_id,struct pt_regs *fp) +{ +struct fb_info *info = dev_id; + +schedule_work (&info->queue); +} +static void cursor_timer_handler (unsigned long dev_addr); static struct timer_list cursor_timer =
@@ -203,7 +232,7 @@ {struct fb_info *info = (struct fb_info *) dev_addr; -fb_vbl_handler (0 , info,NULL ); +schedule_work (&info->queue); cursor_timer.expires = jiffies +HZ /50 ;add_timer (&cursor_timer); }
@@ -290,14 +319,14 @@ const unsigned short *s) {unsigned short charmask = vc->vc_hi_font_mask ?0x1ff :0xff ; -unsigned int width = (vc->vc_font.width +7 )/8 ; +unsigned int width = (vc->vc_font.width +7 ) >>3 ;unsigned int cellsize = vc->vc_font.height * width;unsigned int maxcnt = info->pixmap.size/cellsize;unsigned int shift_low =0 , mod = vc->vc_font.width %8 ;unsigned int shift_high =8 , size, pitch, cnt, k;unsigned int buf_align = info->pixmap.buf_align -1 ;unsigned int scan_align = info->pixmap.scan_align -1 ; -unsigned int idx = vc->vc_font.width/8 ; +unsigned int idx = vc->vc_font.width >>3 ;u8 mask, *src, *dst, *dst0;while (count) {
@@ -307,7 +336,7 @@ cnt = k = count; image->width = vc->vc_font.width * cnt; - pitch = (image->width +7 )/8 + scan_align; + pitch = ((image->width +7 ) >>3 ) + scan_align; pitch &= ~scan_align; size = pitch * vc->vc_font.height + buf_align; size &= ~buf_align;
@@ -338,7 +367,7 @@ const unsigned short *s) {unsigned short charmask = vc->vc_hi_font_mask ?0x1ff :0xff ; -unsigned int width = vc->vc_font.width/8 ; +unsigned int width = vc->vc_font.width >>3 ;unsigned int cellsize = vc->vc_font.height * width;unsigned int maxcnt = info->pixmap.size/cellsize;unsigned int scan_align = info->pixmap.scan_align -1 ;
@@ -411,7 +440,7 @@ int c, int ypos, int xpos) { unsigned short charmask = vc->vc_hi_font_mask ? 0x1ff : 0xff; -unsigned int width = (vc->vc_font.width +7 )/8 ; +unsigned int width = (vc->vc_font.width +7 ) >>3 ;unsigned int scan_align = info->pixmap.scan_align -1 ;unsigned int buf_align = info->pixmap.buf_align -1 ;int bgshift = (vc->vc_hi_font_mask) ?13 :12 ;
@@ -559,6 +588,15 @@ vc = (struct vc_data *)kmalloc (sizeof (struct vc_data ),GFP_ATOMIC ); +if (!vc) { +if (softback_buf) +kfree ((void *) softback_buf); +return NULL ; + } + +/* Initialize the work queue */ +INIT_WORK (&info->queue, fb_callback, info); +/* Setup default font */ vc->vc_font.data = font->data; vc->vc_font.width = font->width;
@@ -956,8 +994,8 @@accel_putcs (vc, info, s, count,real_y (p, ypos), xpos); } -void accel_cursor (struct vc_data *vc,struct fb_info *info,struct fb_cursor *cursor, -int yy) +static void accel_cursor (struct vc_data *vc,struct fb_info *info, +struct fb_cursor *cursor,int yy) {unsigned short charmask = vc->vc_hi_font_mask ?0x1ff :0xff ;int bgshift = (vc->vc_hi_font_mask) ?13 :12 ;
@@ -986,7 +1024,15 @@ size = ((width +7 ) >>3 ) * height; data =kmalloc (size,GFP_KERNEL ); + +if (!data)return ; + mask =kmalloc (size,GFP_KERNEL ); + +if (!mask) { +kfree (data); +return ; + }if (cursor->set &FB_CUR_SETSIZE ) {memset (data,0xff , size);
@@ -1101,27 +1147,6 @@ } } -static void fb_vbl_handler (int irq,void *dev_id,struct pt_regs *fp) -{ -struct fb_info *info = dev_id; -struct display *p = &fb_display[fg_console]; -struct vc_data *vc = vc_cons[fg_console].d; -struct fb_cursor cursor; - -if (!cursor_on) -return ; - -if (vbl_cursor_cnt && --vbl_cursor_cnt ==0 ) { - cursor.set =0 ; - -if (!cursor_drawn) - cursor.set =FB_CUR_SETCUR ; -accel_cursor (vc, info, &cursor,real_y (p, vc->vc_y)); - cursor_drawn ^=1 ; - vbl_cursor_cnt = cursor_blink_rate; - } -} -static int scrollback_phys_max =0 ;static int scrollback_max =0 ;static int scrollback_current =0 ;
drivers/video/softcursor.c +1 -0
@@ -44,6 +44,7 @@if (info->cursor.mask)kfree (info->cursor.mask); info->cursor.mask =kmalloc (dsize,GFP_KERNEL ); +if (!info->cursor.mask)return -ENOMEM ;if (cursor->mask)memcpy (info->cursor.mask, cursor->mask, dsize);else
include/linux/fb.h +3 -1
@@ -2,6 +2,7 @@#define _LINUX_FB_H#include <linux/tty.h> +#include <linux/workqueue.h> #include <asm/types.h> #include <asm/io.h>
@@ -406,8 +407,9 @@struct fb_fix_screeninfo fix;/* Current fix */ struct fb_monspecs monspecs;/* Current Monitor specs */ struct fb_cursor cursor;/* Current cursor */ -struct fb_cmap cmap;/* Current cmap */ +struct work_struct queue;/* Framebuffer event queue */ struct fb_pixmap pixmap;/* Current pixmap */ +struct fb_cmap cmap;/* Current cmap */ struct fb_ops *fbops;char *screen_base;/* Virtual address */ struct vc_data *display_fg;/* Console visible on this display */