Skip to contentSkip to conversation

fix OSS cs4232 linking when compiled-in

PATCH In review Daniel Ritz 2 participants 2 messages Mar 25, 2003 – Mar 26, 2003 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix OSS cs4232 linking when compiled-in

hi

this patch fixes the linking of sound/oss/cs4232.c. unload_cs4232 can't be __exit since it's called from cs_4232_pnp_remove which isn't __exit.

against 2.5.66-bk. please apply.
[fixes bugzilla.kernel.org #499]

rgds
-daniel

===== sound/oss/cs4232.c 1.10 vs edited =====

sound/oss/cs4232.c +1 -1
@@ -313,7 +313,7 @@
 	}
 }
 
-static void __exit unload_cs4232(struct address_info *hw_config)
+static void unload_cs4232(struct address_info *hw_config)
 {
 	int base = hw_config->io_base, irq = hw_config->irq;
 	int dma1 = hw_config->dma, dma2 = hw_config->dma2;
#1 lore raw
Quoted 5 lines · Daniel Ritz

hi

this patch fixes the linking of sound/oss/cs4232.c. unload_cs4232 can't be __exit since it's called from cs_4232_pnp_remove which isn't __exit.

Correct - but surely it shoudl be __devexit ?