Skip to contentSkip to conversation

s390 update (4/9): common i/o layer update.

PATCH Arnd Bergmann 1 participant 1 message Mar 26, 2003 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 5 lines · Christoph Hellwig

Review

Quoted 2 lines · Martin Schwidefsky
(quoted diff) +2 -0
+    typeof (chsc_area_ssd.response_block)
+            *ssd_res = &chsc_area_ssd.response_block;

Yikes! Please use the actual type here instead of typeof()

That code still has a bigger problem and has to be changed anyway. If there is a good reason against typeof, I will do it differently for the final version. This change only kept the hack working with gcc-3.3, I just forgot to do it right before Martin submitted it.

Quoted 7 lines

Review

Quoted 4 lines
(quoted diff) +4 -0
+    if (sch->lpm == 0)
+            return -ENODEV;
+    else
+            return -EACCES;

I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm just too picky..

No, you are right. I'll change it.

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +1 -1
-    sch = kmalloc (sizeof (*sch), GFP_DMA);
+    sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);

What about using GFP_KERNEL | __GFP_DMA instead? This makes it more clear that it's just a qualifier.

Erm, no:

$ find -name \*.c | xargs grep '\<__GFP_DMA' | wc -l
      9
$ find -name \*.c | xargs grep '\<GFP_DMA'  | wc -l
    183

How about changing the few users of __GFP_DMA to GFP_DMA instead?

        Arnd <><