missing sched.h comments
Tidy up sched.h a bit.
(1) ->personality has a "???" comment sitting above it. Comment it.
(2) a comment referring to the nonexistent field ->father from before the pidhash merge persists. Remove the comment. The replacements are all already commented.
(3) ->did_exec, ->leader, ->used_math, and ->keep_capabilities are all boolean, and may fit into the same word. Also comment them.
sched.h | 17 +++++------------ 1 files changed, 5 insertions(+), 12 deletions(-)
include/linux/sched.h +5 -12
@@ -344,21 +344,16 @@ struct task_struct {struct linux_binfmt *binfmt;int exit_code, exit_signal;int pdeath_signal;/* The signal sent when the parent dies */ -/* ??? */ -unsigned long personality; - int did_exec:1; +unsigned long personality;/* personality, which ABI to emulate */ pid_t pid;pid_t pgrp;pid_t tty_old_pgrp;pid_t session;pid_t tgid; -/* boolean value for session group leader */ -int leader; -/* -* pointers to (original) parent process, youngest child, younger sibling, -* older sibling, respectively. (p->father can be replaced with -* p->parent->pid) -*/ + unsigned int leader:1, /* the task is a session leader */ + keep_capabilities:1, /* keep caps after dropping uid 0 */ + used_math:1, /* whether the FPU was used */ + did_exec:1; /* has the process exec()'d */struct task_struct *real_parent;/* real parent process (when being debugged) */ struct task_struct *parent;/* parent process */ struct list_head children;/* list of my children */
@@ -388,11 +383,9 @@ struct task_struct {int ngroups;gid_t groups[NGROUPS ];kernel_cap_t cap_effective, cap_inheritable, cap_permitted; - int keep_capabilities:1;struct user_struct *user;/* limits */ struct rlimit rlim[RLIM_NLIMITS ]; -unsigned short used_math;char comm[16 ];/* file system info */ int link_count, total_link_count;
Quoted 2 lines · William Lee Irwin III
(3) ->did_exec, ->leader, ->used_math, and ->keep_capabilities are all boolean, and may fit into the same word. Also comment them.
Please don't combine used_math - this is set by assembly code, and you can't pass the bit offset of this to asm.
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
Quoted 2 lines · William Lee Irwin III
Quoted 2 lines
(3) ->did_exec, ->leader, ->used_math, and ->keep_capabilities are all boolean, and may fit into the same word. Also comment them.
Quoted 2 lines · Russell King
Please don't combine
used_math- this is set by assembly code, and you can't pass the bit offset of this to asm.
Yuck. I'll not mess with that one, then. But it probably needs a comment:
Tidy up sched.h a bit.
(1) ->personality has a "???" comment sitting above it. Comment it.
(2) a comment referring to the nonexistent field ->father from before the pidhash merge persists. Remove the comment. The replacements are all already commented.
(3) ->did_exec, ->leader, and ->keep_capabilities are all boolean, and may fit into the same word. Also comment them.
(4) used_math is used by assembly, leave it alone, but comment that.
sched.h | 17 +++++------------ 1 files changed, 5 insertions(+), 12 deletions(-)
include/linux/sched.h +5 -12
@@ -344,21 +344,16 @@ struct task_struct {struct linux_binfmt *binfmt;int exit_code, exit_signal;int pdeath_signal;/* The signal sent when the parent dies */ -/* ??? */ -unsigned long personality; - int did_exec:1; +unsigned long personality;/* personality, which ABI to emulate */ pid_t pid;pid_t pgrp;pid_t tty_old_pgrp;pid_t session;pid_t tgid; -/* boolean value for session group leader */ -int leader; -/* -* pointers to (original) parent process, youngest child, younger sibling, -* older sibling, respectively. (p->father can be replaced with -* p->parent->pid) -*/ + unsigned int leader:1, /* boolean value for session leader */ + keep_capabilities:1, /* keep caps after dropping uid 0 */ + did_exec:1; /* has the process exec()'d */ +unsigned short used_math;/* was the FPU used -- touched by asm */ struct task_struct *real_parent;/* real parent process (when being debugged) */ struct task_struct *parent;/* parent process */ struct list_head children;/* list of my children */
@@ -388,11 +383,9 @@ struct task_struct {int ngroups;gid_t groups[NGROUPS ];kernel_cap_t cap_effective, cap_inheritable, cap_permitted; - int keep_capabilities:1;struct user_struct *user;/* limits */ struct rlimit rlim[RLIM_NLIMITS ]; -unsigned short used_math;char comm[16 ];/* file system info */ int link_count, total_link_count;