Skip to contentSkip to conversation

2.5.67 compile problem...

DISCUSSION Bruno Boettcher 3 participants 5 messages Apr 8, 2003 – Apr 10, 2003 Block layer

lore
Share & tools
lore

Bruno Boettcher

author
#0 lore raw

Hello!

after the yesterday cramfs problem, (BTW thanks for those who helped me
iron that out) here another compile problem, with
the patched 2.5.66 thus mathing a 67 kernel:

In file included from include/linux/mca.h:132,
from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:10:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api" drivers/block/ps2esdi.c:182: redefinition of `init_module'
drivers/block/ps2esdi.c:168: `init_module' previously defined here
drivers/block/ps2esdi.c: In function `init_module':
drivers/block/ps2esdi.c:186: warning: initialization from incompatible pointer type drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:190: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:193: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:194: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:196: dereferencing pointer to incomplete type drivers/block/ps2esdi.c: In function `cleanup_module':
drivers/block/ps2esdi.c:212: `i' undeclared (first use in this function) drivers/block/ps2esdi.c:212: (Each undeclared identifier is reported only once drivers/block/ps2esdi.c:212: for each function it appears in.)
drivers/block/ps2esdi.c: In function `do_ps2esdi_request':
drivers/block/ps2esdi.c:502: warning: long long unsigned int format, different type arg (arg 3) drivers/block/ps2esdi.c: In function `ps2esdi_out_cmd_blk':
drivers/block/ps2esdi.c:623: warning: comparison of distinct pointer types lacks a cast drivers/block/ps2esdi.c:646: warning: comparison of distinct pointer types lacks a cast make[2]: *** [drivers/block/ps2esdi.o] Fehler 1

again if someone has a suggestion....
and please add me as CC to any reply

Signature · 5 lines
ciao bboett
==============================================================
[email protected]
http://inforezo.u-strasbg.fr/~bboett
===============================================================
#1 lore raw
Quoted 10 lines · Bruno Boettcher

Hello!

after the yesterday cramfs problem, (BTW thanks for those who helped me
iron that out) here another compile problem, with
the patched 2.5.66 thus mathing a 67 kernel:

[...]

again if someone has a suggestion....
and please add me as CC to any reply

This may fix it. (It's not tested)

Regards Michael Buesch.

block/ps2esdi.c renamed from block/ps2esdi.c.orig +4 -1
@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 

@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);

@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */
#2 lore raw
Quoted 1 line · Michael Buesch

This may fix it. (It's not tested)

partly :D

In file included from include/linux/mca.h:132,
from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:10:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api" drivers/block/ps2esdi.c: In function `init_module':
drivers/block/ps2esdi.c:185: warning: initialization from incompatible pointer type drivers/block/ps2esdi.c:188: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:188: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:192: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:193: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:195: dereferencing pointer to incomplete type drivers/block/ps2esdi.c: In function `do_ps2esdi_request':
drivers/block/ps2esdi.c:505: warning: long long unsigned int format, different type arg (arg 3) drivers/block/ps2esdi.c: In function `ps2esdi_out_cmd_blk':
drivers/block/ps2esdi.c:626: warning: comparison of distinct pointer types lacks a cast drivers/block/ps2esdi.c:649: warning: comparison of distinct pointer types lacks a cast make[2]: *** [drivers/block/ps2esdi.o] Fehler 1

besides debugging this one....
for what is it needed, and can i safely (question there, where?) switch it off, to be able to at least give this 2.5 kernel a test shot?

please add me through CC to any answer

Signature · 5 lines
ciao bboett
==============================================================
[email protected]
http://inforezo.u-strasbg.fr/~bboett
===============================================================
#3 lore raw
Quoted 4 lines · Bruno Boettcher
Quoted 1 line · Michael Buesch

This may fix it. (It's not tested)

partly :D

oops. :) Give this one a try:
(patch against 2.5.67)

block/ps2esdi.c renamed from block/ps2esdi.c.orig +5 -2
@@ -107,7 +107,7 @@
 static int ps2esdi_slot = -1;
 static int tp720esdi = 0;	/* Is it Integrated ESDI of ThinkPad-720? */
 static int intg_esdi = 0;       /* If integrated adapter */
-struct ps2esdi_i_struct {
+struct ps2_esdi_i_struct {
 	unsigned int head, sect, cyl, wpcom, lzone, ctl;
 };
 static spinlock_t ps2esdi_lock = SPIN_LOCK_UNLOCKED;

@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 

@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);

@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */

Regards
Michael Buesch.

Signature · 2 lines
My homepage: http://www.8ung.at/tuxsoft
fighting for peace is like fu**ing for virginity
#4 lore raw
Quoted 8 lines · Michael Buesch
Quoted 4 lines · Bruno Boettcher
Quoted 1 line · Michael Buesch

This may fix it. (It's not tested)

partly :D

oops. :) Give this one a try:
(patch against 2.5.67)

sorry prevoiusly posted patch was wrong.
I hope this one is correct. :D

block/ps2esdi.c renamed from block/ps2esdi.c.orig +5 -2
@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 

@@ -183,7 +182,7 @@
 	int drive;
 
 	for(drive = 0; drive < MAX_HD; drive++) {
-	        struct ps2_esdi_i_struct *info = &ps2esdi_info[drive];
+	        struct ps2esdi_i_struct *info = &ps2esdi_info[drive];
 
         	if (cyl[drive] != -1) {
 		  	info->cyl = info->lzone = cyl[drive];

@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);

@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */

Regards
Michael Buesch.

Signature · 2 lines
My homepage: http://www.8ung.at/tuxsoft
fighting for peace is like fu**ing for virginity