Skip to contentSkip to conversation

APIC is not properly suspending in 2.5.67 on UP

PATCH Pavel Machek 1 participant 1 message Apr 12, 2003

lore
Share & tools
lore
#0 lore raw

Hi!

This is needed otherwise APIC thinks it is not active, does not suspend properly, and kills machine. Extra whitespace killed (looks ugly). Please apply,
Pavel

%patch

arch/i386/kernel/apic.c +1 -6
Index: linux/arch/i386/kernel/apic.c
===================================================================
@@ -449,6 +449,7 @@
 
 	if (nmi_watchdog == NMI_LOCAL_APIC)
 		setup_apic_nmi_watchdog();
+	apic_pm_activate();
 }
 
 #ifdef CONFIG_PM
@@ -652,9 +653,7 @@
 		nmi_watchdog = NMI_LOCAL_APIC;
 
 	printk("Found and enabled local APIC!\n");
-
 	apic_pm_activate();
-
 	return 0;
 
 no_apic:
@@ -1133,11 +1132,8 @@
 	}
 
 	verify_local_APIC();
-
 	connect_bsp_APIC();
-
 	phys_cpu_present_map = 1 << boot_cpu_physical_apicid;
-
 	setup_local_APIC();
 
 	if (nmi_watchdog == NMI_LOCAL_APIC)
@@ -1148,6 +1144,5 @@
 			setup_IO_APIC();
 #endif
 	setup_boot_APIC_clock();
-
 	return 0;
 }

%diffstat

 apic.c |    7 +------
 1 files changed, 1 insertion(+), 6 deletions(-)
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]