SET_MODULE_OWNER comment

PATCH New Rusty Russell 1 participant 1 message Apr 18, 2003 Module support

Share & tools

Rusty Russell

author

2003-04-18 07:12 UTC #0 lore raw

PATCH 1/1 SET_MODULE_OWNER comment

Re-xmit. This should clarify when to use SET_MODULE_OWNER: some people thought it was the One True Way to do the owner assignment.

Linus, pleae apply.
Rusty.

include/linux/module.h +6 -0

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.67-bk1/include/linux/module.h working-2.5.67-bk1-set-owner/include/linux/module.h
@@ -408,6 +408,12 @@ __attribute__((section(".gnu.linkonce.th
 #endif /* MODULE */
 
 #define symbol_request(x) try_then_request_module(symbol_get(x), "symbol:" #x)
+
+/* If you want backwards compat: some structs didn't have owner fields once */
+/* Think of SET_MODULE_OWNER like an IBM mainframe: leave it in a dark 
+   corner for years, don't break it, but don't ever upgrade it either :) 
+   If there is something newer and sexier than the mainframe, it's ok to 
+   use that instead.  The mainframe won't feel lonely. -- Jeff Garzik */
 #define SET_MODULE_OWNER(dev) ((dev)->owner = THIS_MODULE)
 
 /* BELOW HERE ALL THESE ARE OBSOLETE AND WILL VANISH */

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.