Skip to contentSkip to conversation

[2.4] Memleak in Essential RoadRunner HIPPI board driver (resend)

PATCH Oleg Drokin 1 participant 1 message Apr 22, 2003 Network drivers

lore
Share & tools
lore
#0 lore raw

Hello!

I got no reply on the first try. Also the patch is not present neither in current 2.4 bk nor in 2.4.21-pre7-ac2, so I am resending.

----- Forwarded message from Oleg Drokin <[email protected]> -----

Date: Wed, 12 Mar 2003 22:08:46 +0300
From: Oleg Drokin <[email protected]>
To: [email protected], [email protected], [email protected]
Subject: [2.4] Memleak in Essential RoadRunner HIPPI board driver
User-Agent: Mutt/1.4i

Hello!

There is memleak on error exit path. Seems there was some confusion in the mind of whoever added that zeroing statement.
The patch is trivial, 2.5 is not affected.
Found with help of smatch + enhanced unfree script

Bye,
Oleg

===== drivers/net/rrunner.c 1.6 vs edited =====

drivers/net/rrunner.c +0 -1
@@ -1216,7 +1216,6 @@
 
 	rrpriv->info = kmalloc(sizeof(struct rr_info), GFP_KERNEL);
 	if (!rrpriv->info){
-		rrpriv->rx_ctrl = NULL;
 		ecode = -ENOMEM;
 		goto error;
 	}

----- End forwarded message -----