[2.4] Memleak in Aironet 4500 Pcmcia driver

PATCH Oleg Drokin 1 participant 1 message Apr 22, 2003 Network drivers

Share & tools

Oleg Drokin

author

2003-04-22 19:34 UTC #0 lore raw

Hello!

There is a memleak in Aironet 4500 Pcmcia driver on error exit path that is trivial to fix.
Please consider following path.
Found with help of smatch's unfree script.

Bye,
Oleg
===== drivers/net/pcmcia/aironet4500_cs.c 1.8 vs edited =====

drivers/net/pcmcia/aironet4500_cs.c +1 -1

@@ -282,7 +282,7 @@
 	};
 	memset(dev,0,sizeof(struct net_device));
 	dev->priv = kmalloc(sizeof(struct awc_private), GFP_KERNEL);
-	if (!dev->priv ) {printk(KERN_CRIT "out of mem on dev priv alloc \n"); return NULL;};
+	if (!dev->priv ) {printk(KERN_CRIT "out of mem on dev priv alloc \n"); kfree(dev); return NULL;};
 	memset(dev->priv,0,sizeof(struct awc_private));
 	
 //	link->dev->minor = dev->minor;