Skip to contentSkip to conversation

remove devfs hack from misc_register

PATCH New Christoph Hellwig 1 participant 1 message Apr 30, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove devfs hack from misc_register

There's an (fortunately unused) devfs in misc_register currently, when the name of the miscdevice contains a slash the name is used as devfs name instead of misc/<name>. Kill if as we have .devfs_name for this kind of stuff now.

drivers/char/misc.c +2 -11
@@ -192,21 +192,12 @@
 		}
 		misc->minor = i;
 	}
+
 	if (misc->minor < DYNAMIC_MINORS)
 		misc_minors[misc->minor >> 3] |= 1 << (misc->minor & 7);
-
-
-	/*
-	 * please use it if you want to do fancy things with your
-	 * name...
-	 */
 	if (misc->devfs_name[0] == '\0') {
-		/* yuck, yet another stupid special-casing.
-		   whos actually using this?  Please switch over
-		   to ->devfs_name ASAP */
 		snprintf(misc->devfs_name, sizeof(misc->devfs_name),
-				strchr(misc->name, '/') ?
-				  "%s" : "misc/%s", misc->name);
+				"misc/%s", misc->name);
 	}
 
 	devfs_register(NULL, misc->devfs_name, 0, MISC_MAJOR, misc->minor,