Skip to contentSkip to conversation

2.5.68-mm3 and a simple mistake

DISCUSSION Andi Kleen 3 participants 3 messages May 1, 2003 1 message not in the archive

lore
Share & tools
lore

Andi Kleen

author
#1 lore raw
In reply to a message not in the archive
Quoted 8 lines · Kimmo Sundqvist

/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-default /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-generic scripts/Makefile.clean:10: arch/i386/mach-generic/Makefile: No such file or directory
make[2]: *** No rule to make target `arch/i386/mach-generic/Makefile'. Stop. make[1]: *** [_clean_arch/i386/mach-generic] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.68'
make: *** [stamp-kernel-configure] Error 2

Most likely you need to apply this patch. It was in the original subarch patch, but may be gotten lost somewhere. Hopefully not more is missing.

arch/i386/mach-generic/Makefile renamed from arch/i386/mach-generic/Makefile-o +9 -0
diff -u linux-apic/arch/i386/mach-generic/Makefile-o linux-apic/arch/i386/mach-generic/Makefile
@@ -0,0 +1,9 @@
+#
+# Makefile for the generic architecture
+#
+
+EXTRA_CFLAGS	+= -I../kernel
+
+obj-y				:= probe.o summit.o bigsmp.o default.o
+
+

-Andi

#2 lore raw

arch/i386/mach-generic/Makefile line 5

Quoted 2 lines · Andi Kleen
arch/i386/mach-generic/Makefile renamed from arch/i386/mach-generic/Makefile-o +2 -0
+
+EXTRA_CFLAGS	+= -I../kernel

This assignment is not needed AFAICS.
Needs to be removed from a couple of i386 Makefiles, which I will do soon.

Sam

#3 lore raw
In reply to Andi Kleen
Quoted 11 lines · Andi Kleen
Quoted 8 lines · Kimmo Sundqvist

/usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-default /usr/bin/make -f scripts/Makefile.clean obj=arch/i386/mach-generic scripts/Makefile.clean:10: arch/i386/mach-generic/Makefile: No such file or directory
make[2]: *** No rule to make target arch/i386/mach-generic/Makefile'. Stop. make[1]: *** [_clean_arch/i386/mach-generic] Error 2 make[1]: Leaving directory /usr/src/linux-2.5.68'
make: *** [stamp-kernel-configure] Error 2

Quoted 1 line

Most likely you need to apply this patch.

This is funny. Patching with "patch -p0 < 2.5.68-mm3" caused all the patched files to appear in /usr/src/25 They also disappeared from /usr/src/linux-2.5.68

I did "cp -a /usr/src/25/* /usr/src/linux-2.5.68/" and there was no error at first, but the compile failed with:

gcc -Wp,-MD,net/core/.netfilter.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc -iwithprefix include -DKBUILD_BASENAME=netfilter -DKBUILD_MODNAME=netfilter -c -o net/core/netfilter.o net/core/netfilter.c
net/core/netfilter.c: In function `nf_reinject':
net/core/netfilter.c:559: `i' undeclared (first use in this function) net/core/netfilter.c:559: (Each undeclared identifier is reported only once net/core/netfilter.c:559: for each function it appears in.) net/core/netfilter.c:559: warning: left-hand operand of comma expression has no effect
net/core/netfilter.c:559: warning: left-hand operand of comma expression has no effect
make[3]: *** [net/core/netfilter.o] Error 1
make[2]: *** [net/core] Error 2
make[1]: *** [net] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.68'
make: *** [stamp-build] Error 2

Still I can't understand what is the intended way of doing this. I will try n+1 ways and stop to think now and then, but if someone has an easy way to do this, I haven't seen it.

-Kimmo S.