Skip to contentSkip to conversation

kill the last occurances of usb_serial_get_by_minor

PATCH In review Adrian Bunk 2 participants 2 messages May 2, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kill the last occurances of usb_serial_get_by_minor

I got an error at the final linking of 2.5.68-bk11. It seems the patch below is needed.

cu
Adrian

drivers/usb/serial/console.c renamed from drivers/usb/serial/console.c.old +1 -1
@@ -133,7 +133,7 @@
 	co->cflag = cflag;
 
 	/* grab the first serial port that happens to be connected */
-	serial = usb_serial_get_by_minor (0);
+	serial = usb_serial_get_by_index(0);
 	if (serial_paranoia_check (serial, __FUNCTION__)) {
 		/* no device is connected yet, sorry :( */
 		err ("No USB device connected to ttyUSB0");
drivers/usb/serial/usb-serial.h renamed from drivers/usb/serial/usb-serial.h.old +1 -1
@@ -280,7 +280,7 @@
 #endif
 
 /* Functions needed by other parts of the usbserial core */
-extern struct usb_serial *usb_serial_get_by_minor (unsigned int minor);
+extern struct usb_serial *usb_serial_get_by_index (unsigned int minor);
 extern int usb_serial_generic_open (struct usb_serial_port *port, struct file *filp);
 extern int usb_serial_generic_write (struct usb_serial_port *port, int from_user, const unsigned char *buf, int count);
 extern void usb_serial_generic_close (struct usb_serial_port *port, struct file *filp);
#1 lore raw
Quoted 2 lines · Adrian Bunk

I got an error at the final linking of 2.5.68-bk11. It seems the patch below is needed.

Heh, you're using USB_SERIAL_CONSOLE? crazy...

Anyway, yes, you're right. I'll add this to my tree and send it off to Linus in my next round of patches. Thanks a lot for finding this and the patch.

greg k-h