compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
Quoted 2 lines
if(create_file_name (slot_cur, buf)==0)Wow. Three whitespace violations on one line:
- no space after 'if'
- space between function and args
- no space around '==' operator
I know you didn't write that, I just had to comment because it almost hurts to look at it...
Review
Quoted 2 lines
(quoted diff) +1
-1- snprintf (slot_cur->hotplug_slot->name, 30, "%s", ); + snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
Doesn't this need a fourth parameter here instead of just
removing the comma?
Quoted 12 lines · Chuck Ebbert
Quoted 2 lines
if(create_file_name (slot_cur, buf)==0)Wow. Three whitespace violations on one line:
- no space after 'if'
- space between function and args
- no space around '==' operatorI know you didn't write that, I just had to comment because it almost hurts to look at it...
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- snprintf (slot_cur->hotplug_slot->name, 30, "%s", ); + snprintf (slot_cur->hotplug_slot->name, 30, "%s" );Doesn't this need a fourth parameter here instead of just
removing the comma?
Yes, Andreas Haumer fixed the compile problems correctly in his post.
Geller Sandor <[email protected]>