Skip to contentSkip to conversation

Typo in arch/sh/kernel/io_7751se.c

DISCUSSION Paul van Gool 2 participants 3 messages May 7, 2003

lore
Share & tools
lore
#0 lore raw

Hi,

not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending it to this mailing list.

While building a kernel for an SH7751 SolutionEngine, I ran into a link problem using a non-PCI configuration. I tracked the problem back to arch/sh/kernel/io_7751se.c. On line 304, I see:

#if defined(CONFIG_PCI)
#define CHECK_SH7751_PCIIO(port) \
((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
#else
#define CHECK_SH_7751_PCIIO(port) (0)
#endif

The problem is with the 5th line. It should be:

#define CHECK_SH7751_PCIIO(port) (0)

I removed the '_' between SH and 7751.

If I need to send this somewhere else, please tell me where.

Thanks.

Paul

Signature · 2 lines
Paul van Gool                                               Rincon Networks
[email protected]                              (805)-705-1442
#1 lore raw
Quoted 3 lines · Paul van Gool

not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending it to this mailing list.

Please send all SH related bugs to [email protected]. Consult MAINTAINERS for additional links.

Quoted 11 lines

While building a kernel for an SH7751 SolutionEngine, I ran into a link problem using a non-PCI configuration. I tracked the problem back to arch/sh/kernel/io_7751se.c. On line 304, I see:

#if defined(CONFIG_PCI)
#define CHECK_SH7751_PCIIO(port) \
((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
#else
#define CHECK_SH_7751_PCIIO(port) (0)
#endif

Quoted 6 lines

The problem is with the 5th line. It should be:

#define CHECK_SH7751_PCIIO(port) (0)

I removed the '_' between SH and 7751.

This issue has already been fixed in the LinuxSH CVS for both 2.4 and 2.5. Since I just synced 2.5 over, I guess its time for a 2.4 update..

#2 lore raw

Thanks, Paul.

Paul

Quoted 26 lines · Paul Mundt
Quoted 3 lines · Paul van Gool

not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending it to this mailing list.

Please send all SH related bugs to [email protected]. Consult MAINTAINERS for additional links.

Quoted 11 lines

While building a kernel for an SH7751 SolutionEngine, I ran into a link problem using a non-PCI configuration. I tracked the problem back to arch/sh/kernel/io_7751se.c. On line 304, I see:

#if defined(CONFIG_PCI)
#define CHECK_SH7751_PCIIO(port) \
((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
#else
#define CHECK_SH_7751_PCIIO(port) (0)
#endif

Quoted 6 lines

The problem is with the 5th line. It should be:

#define CHECK_SH7751_PCIIO(port) (0)

I removed the '_' between SH and 7751.

This issue has already been fixed in the LinuxSH CVS for both 2.4 and 2.5. Since I just synced 2.5 over, I guess its time for a 2.4 update..

Signature · 2 lines
Paul van Gool                                               Rincon Networks
[email protected]                              (805)-705-1442