Skip to contentSkip to conversation

PATCH 2.5.69 drivers/macintosh/adbhid.c && QUESTIONS

PATCH Daniele Pala 2 participants 2 messages May 7, 2003 – May 11, 2003 Linux for power macintosh

lore
Share & tools
lore
#0 lore raw

This fixes a supid syntax error in adbhid.c
The question is: is there a PPC mantainer who i must send patches for PPC? or i just drop them here in the list? There are other few errors in PPC related files that sometimes prevents the kernel from compiling...supid things, but annoying...so who gets the PPC stuff?

Regards,
Daniele Pala

drivers/macintosh/adbhid.c: In function `adbhid_keyboard_input':
drivers/macintosh/adbhid.c:137: too many arguments to function adbhid_input_keycode' drivers/macintosh/adbhid.c:139: too many arguments to function adbhid_input_keycode' drivers/macintosh/adbhid.c: At top level:
drivers/macintosh/adbhid.c:143: parse error before pt_regs' drivers/macintosh/adbhid.c: In function adbhid_input_keycode':
drivers/macintosh/adbhid.c:144: number of arguments doesn't match prototype drivers/macintosh/adbhid.c:87: prototype declaration drivers/macintosh/adbhid.c:147: `keycode' undeclared (first use in this function) drivers/macintosh/adbhid.c:147: (Each undeclared identifier is reported only once drivers/macintosh/adbhid.c:147: for each function it appears in.) drivers/macintosh/adbhid.c:152: id' undeclared (first use in this function) drivers/macintosh/adbhid.c:152: regs' undeclared (first use in this function) make[2]: *** [drivers/macintosh/adbhid.o] Error 1
make[1]: *** [drivers/macintosh] Error 2
make: *** [drivers] Error 2

adbhid.c renamed from drivers/macintosh/adbhid.c +2 -2
@@ -84,7 +84,7 @@
 
 static void adbhid_probe(void);
 
-static void adbhid_input_keycode(int, int, int);
+static void adbhid_input_keycode(int, int, int, struct pt_regs *);
 static void leds_done(struct adb_request *);
 
 static void init_trackpad(int id);
@@ -140,7 +140,7 @@
 }
 
 static void
-adbhid_input_keycode(int id, int keycode, int repeat, pt_regs *regs)
+adbhid_input_keycode(int id, int keycode, int repeat, struct pt_regs *regs)
 {
 	int up_flag;
 
#1 lore raw
Quoted 4 lines · Daniele Pala

This fixes a supid syntax error in adbhid.c
The question is: is there a PPC mantainer who i must send patches for PPC? or i just drop them here in the list? There are other few errors in PPC related files that sometimes prevents the kernel from compiling...supid things, but annoying...so who gets the PPC stuff?

There is a PowerMac maintainer, me ;) Though I've been a bit busy with other things than 2.5 PowerMac drivers lately, still send me the patches.

You will also have more luck using the bk://ppc.bkbits.net/linuxppc-2.5 tree until all of our stuff is properly merged upstream

Ben.