Skip to contentSkip to conversation

Problems with 25_natcore-nohelper patch

PATCH Jeff Hall 2 participants 2 messages May 9, 2003 – Jul 4, 2003 1 message not in the archive netfilter

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jeff Hall

author
#1 lore raw

Did you also apply the patches below? They're from a message to Harald Welte on 2003/4/8 and I believe they pertain to the problem you're having.

I tested the pptp client from sourceforge.net on a machine also running a PoPToP server and was able to make a successful outgoing connection from that machine.

If these patches don't solve your problem, let me know and I'll send you all the pertinent sources.

Quoted 12 lines · Raivis Bucis

Hello,

I would like to inform you that width 25_natcore-nohelper patch PPTP NAT stops working correctly. Specifically PPTP client (PAC) on the box that has ip_nat_pptp.o loaded doesn't work.

Since PPTP NAT allways changes callerID, it is required that pptp_nat helper is also allways called, but pptp client TCP controlling connection doesn't have any manips, and only associated GRE conntrack has manips for callerID changing. So pptp_nat helper can not change callerID in controll connection and PPTP doesn't work anymore.

Quoted 4 lines

Is this a known problem?

Raivis

ip_conntrack_pptp.c Thu Apr 3 03:56:59 2003 renamed from ip_conntrack_pptp.v1_8 Tue Apr 8 06:02:29 2003 +1 -0
@@ -124,6 +124,7 @@
 			/* remove only if occurred at same sequence number */
 			if (other_exp != exp && other_exp->seq == exp->seq) {
 				DEBUGP("unexpecting other direction\n");
+				ip_ct_gre_keymap_destroy(other_exp);
 				ip_conntrack_unexpect_related(other_exp);
 			}
 		}
ip_nat_standalone.c Thu Apr 3 19:52:09 2003 renamed from ip_nat_standalone.c.prepatch Sun Mar 16 01:41:45 2003 +6 -1
@@ -121,8 +121,13 @@
 			if (ct->master
 			    && master_ct(ct)->nat.info.helper
 			    && master_ct(ct)->nat.info.helper->expect) {
-				ret = call_expect(master_ct(ct), pskb, 
+				if(master_ct(ct)->nat.info.num_manips) {
+					ret = call_expect(master_ct(ct), pskb, 
 						hooknum, ct, info);
+				} else {
+					WRITE_UNLOCK(&ip_nat_lock);
+					return NF_ACCEPT;
+				}
 			} else {
 #ifdef CONFIG_IP_NF_NAT_LOCAL
 				/* LOCAL_IN hook doesn't have a chain and thus
#2 lore raw
Quoted 4 lines · Jeff Hall

Did you also apply the patches below? They're from a message to Harald Welte on 2003/4/8 and I believe they pertain to the problem you're having.

Quoted 23 lines

I tested the pptp client from sourceforge.net on a machine also running a PoPToP server and was able to make a successful outgoing connection from that machine.

If these patches don't solve your problem, let me know and I'll send you all the pertinent sources.

Quoted 14 lines · Raivis Bucis

I would like to inform you that width 25_natcore-nohelper patch PPTP NAT stops working correctly. Specifically PPTP client (PAC) on the box that has ip_nat_pptp.o loaded doesn't work.

Since PPTP NAT allways changes callerID, it is required that pptp_nat helper is also allways called, but pptp client TCP controlling connection doesn't have any manips, and only associated GRE conntrack has manips for callerID changing. So pptp_nat helper can not change callerID in controll connection and PPTP doesn't work anymore.

Is this a known problem?

Raivis

Since I didn't receive any update on this issue: Raivis, ist the problem now solved when this patchlet from Jeffs original mail (also submitted to the mainstream kernel since 2.4.20)had been applied?

Quoted 6 lines
ip_nat_standalone.c Thu Apr 3 19:52:09 2003 renamed from ip_nat_standalone.c.prepatch Sun Mar 16 01:41:45 2003 +0 -0
@@ -121,8 +121,13 @@
 			if (ct->master
 			    && master_ct(ct)->nat.info.helper
 			    && master_ct(ct)->nat.info.helper->expect) {

ip_nat_standalone.c Thu Apr 3 19:52:09 2003 line 132

Quoted 10 lines
ip_nat_standalone.c Thu Apr 3 19:52:09 2003 renamed from ip_nat_standalone.c.prepatch Sun Mar 16 01:41:45 2003 +6 -1
-				ret = call_expect(master_ct(ct), pskb, 
+				if(master_ct(ct)->nat.info.num_manips) {
+					ret = call_expect(master_ct(ct), pskb, 
 						hooknum, ct, info);
+				} else {
+					WRITE_UNLOCK(&ip_nat_lock);
+					return NF_ACCEPT;
+				}
 			} else {
 #ifdef CONFIG_IP_NF_NAT_LOCAL

alternatively, please try a 2.4.21 kernel with the pptp patch from patch-o-matic and tell me if the problem still persists.

thanks.

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie