Skip to contentSkip to conversation

remove all #include <blk.h>'s

PATCH In review Adrian Bunk 2 participants 5 messages May 10, 2003 – May 11, 2003

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 remove all #include <blk.h>'s

The attached patch (gzipped due to 100 kB linux-kernel limit) removes all #include <blk.h>'s for 2.5 and blk.h does now #error. If people want their drivers to run unmodified under 2.4 it might be necessary to do a
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
#include <linux/blk.h>
#endif

I've tested the compilation in 2.5.69-bk4 with a .config that tries to compile as much drivers as possible.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#1 lore raw
Quoted 8 lines · Adrian Bunk

The attached patch (gzipped due to 100 kB linux-kernel limit) removes all #include <blk.h>'s for 2.5 and blk.h does now #error. If people want their drivers to run unmodified under 2.4 it might be necessary to do a
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
#include <linux/blk.h>
#endif

Quoted 5 lines

I've tested the compilation in 2.5.69-bk4 with a .config that tries to compile as much drivers as possible.

cu
Adrian

Ups, forgot to attach the file...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
In reply to Adrian Bunk
Quoted 1 line · Adrian Bunk

all #include <blk.h>'s for 2.5 and blk.h does now #error. If people

I think that's _really_ stupid. Make it a warning ala

#warning blk.h is deprecated, use blkdev.h

like we did with malloc.h in 2.4.

Quoted 5 lines

want their drivers to run unmodified under 2.4 it might be necessary to do a
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,70)
#include <linux/blk.h>
#endif

That is horrible.

Signature · 1 line
Jens Axboe
author
#3 lore raw
Quoted 9 lines · Jens Axboe
Quoted 1 line · Adrian Bunk

all #include <blk.h>'s for 2.5 and blk.h does now #error. If people

I think that's _really_ stupid. Make it a warning ala

#warning blk.h is deprecated, use blkdev.h

like we did with malloc.h in 2.4.
...

Changed patch is attached.

Quoted 1 line

Jens Axboe

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Jens Axboe
Quoted 1 line · Adrian Bunk

all #include <blk.h>'s for 2.5 and blk.h does now #error. If people

Quoted 8 lines
Quoted 6 lines

I think that's _really_ stupid. Make it a warning ala

#warning blk.h is deprecated, use blkdev.h

like we did with malloc.h in 2.4.
...

Changed patch is attached.

Cool thanks, I greatly prefer this variant. And thanks for doing this work, btw.

Signature · 1 line
Jens Axboe