Skip to contentSkip to conversation

2.4.21-rc1 fix to drivers/ide/Config.in

RFC PATCH New Joe Korty 1 participant 1 message May 12, 2003

lore
Share & tools
lore

Joe Korty

author
#0 lore raw

RFC PATCH 1/1 2.4.21-rc1 fix to drivers/ide/Config.in

Alan,
On April 1 Marcello accepted a patch to ide/drivers/Config.in that breaks
'make xconfig'. The error is on line 46, where a new dep_tristate variable was defined without the conditional value that dep_tristate requires. Apparently 'make config', 'make oldconfig', etc are able to handle this syntax error somehow but 'make xconfig' cannot.

The attached patch is my guess as to what the conditional should be. Could you verify that it is correct and let Marcelo know? Several such patches have been floated by others to Marcelo in the past but none have been accepted, possibly because he wants your blessing on changes to your code made by others.

Thanks,
Joe

ide/Config.in renamed from ide/Config.in.orig +1 -1
@@ -43,7 +43,7 @@
 	    define_bool CONFIG_BLK_DEV_IDEDMA $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_bool '      ATA Work(s) In Progress (EXPERIMENTAL)' CONFIG_IDEDMA_PCI_WIP $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_EXPERIMENTAL
 #	    dep_bool '      Good-Bad DMA Model-Firmware (WIP)' CONFIG_IDEDMA_NEW_DRIVE_LISTINGS $CONFIG_IDEDMA_PCI_WIP
-            dep_tristate '    Pacific Digital ADMA-100 basic support' CONFIG_BLK_DEV_ADMA100
+            dep_tristate '    Pacific Digital ADMA-100 basic support' CONFIG_BLK_DEV_ADMA100 $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    AEC62XX chipset support' CONFIG_BLK_DEV_AEC62XX $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    ALI M15x3 chipset support' CONFIG_BLK_DEV_ALI15X3 $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_mbool    '      ALI M15x3 WDC support (DANGEROUS)' CONFIG_WDC_ALI15X3 $CONFIG_BLK_DEV_ALI15X3