2.5.69-mm6

DISCUSSION Alistair Strachan 2 participants 2 messages May 16, 2003 Network drivers

Share & tools

Alistair Strachan

author

2003-05-16 19:23 UTC #0 lore raw

Quoted 10 lines · Andrew Morton

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.69/2.5.69-mm6/
. A forward-port of reiserfs `chattr' support.
. Some anticipatory scheduler work. It will affect performance,
hopefully positively.
. Random other fixes, cleanups and featurettes.

[SNIP]

Hi,

Just a quick note to alert you to a problem versus 2.5.69 virgin. In dmesg, I see the following:

failed to register PPP device (0)

Despite this, ppp seems to work fine, and the /dev/ppp device is generated by devfs (was it /dev/ppp0 before?). Any ideas?

Cheers,
Alistair.

Andrew Morton

2003-05-16 20:58 UTC #1 lore raw

Quoted 5 lines · Alistair Strachan

Just a quick note to alert you to a problem versus 2.5.69 virgin. In dmesg, I see the following:
failed to register PPP device (0)

ah, thanks. Easily fixed.

drivers/net/ppp_generic.c renamed from drivers/net/ppp_generic.c~ppp-warning-fix +1 -1

diff -puN drivers/net/ppp_generic.c~ppp-warning-fix drivers/net/ppp_generic.c
@@ -803,7 +803,7 @@ int __init ppp_init(void)
 				S_IFCHR|S_IRUSR|S_IWUSR, "ppp");
 	}
 
-	if (!err)
+	if (err)
 		printk(KERN_ERR "failed to register PPP device (%d)\n", err);
 	return err;
 }