Skip to contentSkip to conversation

[2.5] static MAX_MP_BUSSES increase for Summit boxes

PATCH In review James Cleverdon 3 participants 3 messages May 24, 2003 – May 27, 2003

lore
Share & tools
lore

James Cleverdon

author
#0 lore raw

PATCH 1/1 [2.5] static MAX_MP_BUSSES increase for Summit boxes

The dynamic MAX_MP_BUSSES fix for v2.4 never made it into 2.5. x440s with RXE100s and 32-way x445s without can easily overflow it.

Here's a static patch:

include/asm-i386/mpspec.h +6 -0
diff -pru 2.5.69/include/asm-i386/mpspec.h t69/include/asm-i386/mpspec.h
@@ -191,7 +191,13 @@ struct mpc_config_translation
 #define MAX_IRQ_SOURCES 256
 #endif /* CONFIG_X86_NUMAQ */
 
+#ifdef CONFIG_X86_SUMMIT
+/* BIOS reserves an amazing number of PCI busses on x440s and x445s,
+ * especially when RXE100s are attached. */
+#define MAX_MP_BUSSES 258
+#else
 #define MAX_MP_BUSSES 32
+#endif
 enum mp_bustype {
 	MP_BUS_ISA = 1,
 	MP_BUS_EISA,
Signature · 3 lines
James Cleverdon
IBM xSeries Linux Solutions
{jamesclv(Unix, preferred), cleverdj(Notes)} at us dot ibm dot com
#1 lore raw
Quoted 4 lines · James Cleverdon

The dynamic MAX_MP_BUSSES fix for v2.4 never made it into 2.5. x440s with RXE100s and 32-way x445s without can easily overflow it.

Here's a static patch:

Umm, no. Please forward port the dynamic MAX_MP_BUSSES changes instead of such a hack.

#2 lore raw
In reply to James Cleverdon
Quoted 4 lines · James Cleverdon

The dynamic MAX_MP_BUSSES fix for v2.4 never made it into 2.5. x440s with RXE100s and 32-way x445s without can easily overflow it.

Here's a static patch:

Port the proper fix surely