Some subarch warning fixes

PATCH New Andi Kleen 1 participant 1 message May 31, 2003

Share & tools

Andi Kleen

author

2003-05-31 11:47 UTC #0 lore raw

PATCH 1/1 Some subarch warning fixes

Some recent subarch interface changes caused macro redefinition warnings for GET_APIC_ID and APIC_ID_MASK with the generic subarchitecture. Fixing it properly required some reorganization by giving the generic arch a mach_apicdef.h too.

-Andi

Index: linux/arch/i386/mach-generic/default.c
===================================================================
RCS file: /home/cvs/linux-2.5/arch/i386/mach-generic/default.c,v retrieving revision 1.11

arch/i386/mach-generic/default.c +1 -1

diff -u -u -r1.11 default.c
@@ -2,6 +2,7 @@
  * Default generic APIC driver. This handles upto 8 CPUs.
  */
 #define APIC_DEFINITION 1
+#include <asm/mach-default/mach_apicdef.h>
 #include <asm/genapic.h>
 #include <asm/fixmap.h>
 #include <asm/apicdef.h>

@@ -10,7 +11,6 @@
 #include <linux/smp.h>
 #include <linux/init.h>
 #include <asm/mach-default/mach_apic.h>
-#include <asm/mach-default/mach_apicdef.h>
 #include <asm/mach-default/mach_ipi.h>
 #include <asm/mach-default/mach_mpparse.h>

Index: linux/include/asm-i386/mach-generic/mach_apic.h
===================================================================
RCS file: /home/cvs/linux-2.5/include/asm-i386/mach-generic/mach_apic.h,v retrieving revision 1.11

include/asm-i386/mach-generic/mach_apic.h +0 -2

diff -u -u -r1.11 mach_apic.h
@@ -24,8 +24,6 @@
 #define check_apicid_present (genapic->check_apicid_present)
 #define check_phys_apicid_present (genapic->check_phys_apicid_present)
 #define check_apicid_used (genapic->check_apicid_used)
-#define GET_APIC_ID (genapic->get_apic_id)
-#define APIC_ID_MASK (genapic->apic_id_mask)
 #define cpu_mask_to_apicid (genapic->cpu_mask_to_apicid)
 
 #endif /* __ASM_MACH_APIC_H */

include/asm-i386/mach-generic/mach_apicdef.h new file +11 -0

@@ -0,0 +1,11 @@
+#ifndef _GENAPIC_MACH_APICDEF_H
+#define _GENAPIC_MACH_APICDEF_H 1
+
+#ifndef APIC_DEFINITION
+#include <asm/genapic.h>
+
+#define GET_APIC_ID (genapic->get_apic_id)
+#define APIC_ID_MASK (genapic->apic_id_mask)
+#endif
+
+#endif