Skip to contentSkip to conversation

PCI: move pci_present() into drivers/pci/search.c

PATCH Jeff Garzik 2 participants 2 messages Jun 6, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · Linux Kernel Mailing List

ChangeSet 1.1317, 2003/06/05 12:04:33-07:00, [email protected]

[PATCH] PCI: move pci_present() into drivers/pci/search.c

This will let not have to export the pci_devices variable.

pci_present() should be killed. It's left over from 2.0 or 1.2 days, and has no meaning anymore.

The old-kernel use was to determine if a PCI bus. Drivers had to check if a PCI bus was present, before probing for a PCI device using the old-old find-by-slot-and-busid method of PCI bus probing. As the now-old method of PCI bus probing (pci_find_device) and the current PCI API both provide correct behavior when no PCI bus is present, pci_present() itself no longer has any meaning and is entirely redundant.

At the very least, we should use the gcc "deprecated" attribute on pci_present definitions, both normal and no-op.

IMO pci_present should go before 2.6.0... it's lived long enough.

Jeff

#2 lore raw
Quoted 2 lines · Jeff Garzik

IMO pci_present should go before 2.6.0... it's lived long enough.

Good point, I agree. I'll see about making these changes after I finish some of these other PCI changes.

thanks,

greg k-h