don't dereference sdev->access_count in dpt_i2o
PATCH 1/1 don't dereference sdev->access_count in dpt_i2o
This is nothing a LLDD should ever look at and might go away completly soon. The uses are for a printk and a racy ioctl.
drivers/scsi/dpt_i2o.c +0 -24
@@ -1949,25 +1949,5 @@case I2ORESCANCMD :adpt_rescan (pHba);break ; -case DPT_TARGET_BUSY &0xFFFF : -case DPT_TARGET_BUSY : - { -TARGET_BUSY_T busy; -struct adpt_device * d; - -if (copy_from_user ((void *)&busy, (void *)arg,sizeof (TARGET_BUSY_T ))) { -return -EFAULT ; - } - - d =adpt_find_device (pHba, busy.channel, busy.id, busy.lun); -if (d ==NULL ){ -return -ENODEV ; - } - busy.isBusy = ((d->pScsi_dev) && (0 != d->pScsi_dev->access_count)) ?1 :0 ; -if (copy_to_user ((char *)arg, &busy,sizeof (busy))) { -return -EFAULT ; - } -break ; - }default :return -EINVAL ;
@@ -2492,10 +2473,6 @@printk (KERN_WARNING "%s: Device (%d,%d,%d) offline\n" ,pHba->name,pDev->scsi_channel,pDev->scsi_id,pDev->scsi_lun);if (pDev->pScsi_dev) { pDev->pScsi_dev->online = FALSE; -if (pDev->pScsi_dev->access_count) { -// A drive that was mounted is no longer there... bad! -printk (KERN_WARNING "%s:Mounted drive taken offline\n" ,pHba->name); - } } } }