Skip to contentSkip to conversation

ehci_hcd.c linkage fix

PATCH In review Andrew Morton 2 participants 2 messages Jun 19, 2003

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Andrew Morton

author
#0 lore raw

PATCH 1/1 ehci_hcd.c linkage fix

With CONFIG_HOTPLUG=n we get, at link time:

drivers/usb/host/ehci-hcd.c:977: pci_ids causes a section type conflict

The fix is to remove the const, but I'm darned if I can remember why. Can anyone remind me?

drivers/usb/host/ehci-hcd.c renamed from drivers/usb/host/ehci-hcd.c~ehci_hcd-linkage-fix +1 -1
@@ -974,7 +974,7 @@ static const struct hc_driver ehci_drive
 /* EHCI spec says PCI is required. */
 
 /* PCI driver selection metadata; PCI hotplugging uses this */
-static const struct pci_device_id __devinitdata pci_ids [] = { {
+static struct pci_device_id __devinitdata pci_ids [] = { {
 
 	/* handle any USB 2.0 EHCI controller */

_

#1 lore raw
Quoted 8 lines · Andrew Morton

With CONFIG_HOTPLUG=n we get, at link time:

drivers/usb/host/ehci-hcd.c:977: pci_ids causes a section type conflict

The fix is to remove the const, but I'm darned if I can remember why. Can anyone remind me?

I have no idea why, I haven't heard of that one before.

greg k-h