Skip to contentSkip to conversation

fix sysfs bogosity in i82365.c

PATCH New Arnaldo Carvalho de Melo 1 participant 1 message Jun 22, 2003 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix sysfs bogosity in i82365.c

Hi Linus,

	Please consider applying, it was using a non-existent socket[] index

and not doing it for all sockets.

Without this, forget about using i82365, crashes on boot :-)

- Arnaldo

===== drivers/pcmcia/i82365.c 1.36 vs edited =====

drivers/pcmcia/i82365.c +4 -3
@@ -1471,6 +1471,10 @@
 			    pcmcia_unregister_socket(&socket[i].socket);
 		    break;
 	    }
+	   class_device_create_file(&socket[i].socket.dev,
+			   	    &class_device_attr_info);
+	   class_device_create_file(&socket[i].socket.dev,
+			   	    &class_device_attr_exca);
     }
 
     /* Finally, schedule a polling interrupt */
@@ -1481,9 +1485,6 @@
     	poll_timer.expires = jiffies + poll_interval;
 	add_timer(&poll_timer);
     }
-
-    class_device_create_file(&socket[i].socket.dev, &class_device_attr_info);
-    class_device_create_file(&socket[i].socket.dev, &class_device_attr_exca);
     
     return 0;