Skip to contentSkip to conversation

Early mail about synaptics driver

DISCUSSION Applied Peter Osterlund 2 participants 2 messages Jul 4, 2003 – Jul 5, 2003 1 message not in the archive Input drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Peter Osterlund

author
#1 lore raw
Quoted 8 lines · P. Christeas

I am trying to use your synaptics kernel driver. I do have the touchpad, which means that as from 2.573 the kernel tries to use that by default.

The other important part (which I have solved) is that you set "disable gestures" by default. I don't know if this is required in absolute mode, but it surely makes the touchpad less useful in relative mode. That is, if I unload the module and reload it with 'psmouse_noext=1' [1], then the previous setting [2] applies and gestures are disabled.

I think it would be better to restore default settings when the driver is unloaded, as in the patch below. I have verified that this patch solves the problem on my computer using kernel 2.5.74.

drivers/input/mouse/psmouse-base.c renamed from drivers/input/mouse.orig/psmouse-base.c +2 -1
diff -u -r linux/drivers/input/mouse.orig/psmouse-base.c linux/drivers/input/mouse/psmouse-base.c
@@ -478,9 +478,10 @@
 static void psmouse_disconnect(struct serio *serio)
 {
 	struct psmouse *psmouse = serio->private;
+	if (psmouse->type == PSMOUSE_SYNAPTICS)
+		synaptics_disconnect(psmouse);
 	input_unregister_device(&psmouse->dev);
 	serio_close(serio);
-	synaptics_disconnect(psmouse);
 	kfree(psmouse);
 }
drivers/input/mouse/synaptics.c renamed from drivers/input/mouse.orig/synaptics.c +5 -2
diff -u -r linux/drivers/input/mouse.orig/synaptics.c linux/drivers/input/mouse/synaptics.c
@@ -144,7 +144,7 @@
 static void print_ident(struct synaptics_data *priv)
 {
 	printk(KERN_INFO "Synaptics Touchpad, model: %ld\n", SYN_ID_MODEL(priv->identity));
-	printk(KERN_INFO " Firware: %ld.%ld\n", SYN_ID_MAJOR(priv->identity),
+	printk(KERN_INFO " Firmware: %ld.%ld\n", SYN_ID_MAJOR(priv->identity),
 	       SYN_ID_MINOR(priv->identity));
 
 	if (SYN_MODEL_ROT180(priv->model_id))

@@ -228,7 +228,7 @@
 	/*
 	 * The x/y limits are taken from the Synaptics TouchPad interfacing Guide,
 	 * which says that they should be valid regardless of the actual size of
-	 * the senser.
+	 * the sensor.
 	 */
 	set_bit(EV_ABS, psmouse->dev.evbit);
 	set_abs_params(&psmouse->dev, ABS_X, 1472, 5472, 0, 0);

@@ -259,6 +259,9 @@
 {
 	struct synaptics_data *priv = psmouse->private;
 
+	/* Restore touchpad to power on default state */
+	synaptics_set_mode(psmouse, 0);
+
 	kfree(priv);
 }
Signature · 2 lines
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340
Applied
#2 lore raw
Quoted 11 lines · Peter Osterlund
Quoted 8 lines · P. Christeas

I am trying to use your synaptics kernel driver. I do have the touchpad, which means that as from 2.573 the kernel tries to use that by default.

The other important part (which I have solved) is that you set "disable gestures" by default. I don't know if this is required in absolute mode, but it surely makes the touchpad less useful in relative mode. That is, if I unload the module and reload it with 'psmouse_noext=1' [1], then the previous setting [2] applies and gestures are disabled.

Quoted 3 lines

I think it would be better to restore default settings when the driver is unloaded, as in the patch below. I have verified that this patch solves the problem on my computer using kernel 2.5.74.

Thanks, applied.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR