Skip to contentSkip to conversation

help backporting workqueue to 2.4; for net/sunrpc/cache.c

DISCUSSION Frank Cusack 3 participants 3 messages Jul 4, 2003

lore
Share & tools
lore
#0 lore raw

Hi all,

Should I expect any problems backporting the 2.5 workqueue.c to 2.4? It looks pretty straightforward, but I am {naive,novice}. The only interesting looking bit is setting current->flags |= PF_IOTHREAD, which doesn't exist in 2.4. At a glance, it looks like I can ignore this; it's used in suspend.c which doesn't exist in 2.4 either.

The reason I'd like to backport this is because of changes in sunrpc which now use the workqueue to clean auth caches. Related question:
how is this (periodic cache clean) done in 2.5.73 and earlier? net/sunrpc/cache.c didn't use the workqueue until 2.5.74.

Any advice is appreciated.

thanks
/fc

#1 lore raw
Quoted 8 lines · On Friday July 4, [email protected] wrote:

Hi all,

Should I expect any problems backporting the 2.5 workqueue.c to 2.4? It looks pretty straightforward, but I am {naive,novice}. The only interesting looking bit is setting current->flags |= PF_IOTHREAD, which doesn't exist in 2.4. At a glance, it looks like I can ignore this; it's used in suspend.c which doesn't exist in 2.4 either.

Quoted 4 lines

The reason I'd like to backport this is because of changes in sunrpc which now use the workqueue to clean auth caches. Related question:
how is this (periodic cache clean) done in 2.5.73 and earlier? net/sunrpc/cache.c didn't use the workqueue until 2.5.74.

The nfsd threads called cache_clean() from nfsd() in nfsd/nfssvc.c, whenever they didn't have anything else to do, but this wasn't really often enough. You could probably get them to do it after every request as cache_clean() does virtually nothing unless there is evidence that something needs doing.

NeilBrown

Quoted 10 lines

Any advice is appreciated.

thanks
/fc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/