2.4.22-pre3: P3 and P4 for chekc_gcc
PATCH 1/1 2.4.22-pre3: P3 and P4 for chekc_gcc
Hi all...
Her it goes again, just the P3 and P4 part.
arch/i386/Makefile renamed from arch/i386/Makefile.orig +2 -2
@@ -53,11 +53,11 @@ endif ifdef CONFIG_MPENTIUMIII -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686) endif ifdef CONFIG_MPENTIUM4 -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686) endif ifdef CONFIG_MK6
Signature · 4 lines
J.A. Magallon <[email protected]> \ Software is like sex: werewolf.able.es \ It's better when it's free Mandrake Linux release 9.2 (Cooker) for i586 Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))
Quoted 4 lines · J.A. Magallon
arch/i386/Makefile renamed from arch/i386/Makefile.orig +0
-0@@ -53,11 +53,11 @@ endif
arch/i386/Makefile line 61
Quoted 10 lines
arch/i386/Makefile renamed from arch/i386/Makefile.orig +2
-2ifdef CONFIG_MPENTIUMIII -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686) endif ifdef CONFIG_MPENTIUM4 -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686) endif
Looks ok to me (I run this patch locally, and also am the one who submitted the check_gcc patch).
I haven't had any problems at all, but I'm curious if anyone has any negative feedback... It's rather easy to be conservative and ignore the patch, since -march=i686 should always work.
Jeff
Quoted 20 lines · Jeff Garzik
Quoted 4 lines · J.A. Magallon
arch/i386/Makefile renamed from arch/i386/Makefile.orig +0
-0@@ -53,11 +53,11 @@ endifarch/i386/Makefile line 61
Quoted 10 lines
arch/i386/Makefile renamed from arch/i386/Makefile.orig +2
-2ifdef CONFIG_MPENTIUMIII -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686) endif ifdef CONFIG_MPENTIUM4 -CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686) endifLooks ok to me (I run this patch locally, and also am the one who submitted the
check_gccpatch).
Quoted 4 lines
I haven't had any problems at all, but I'm curious if anyone has any negative feedback... It's rather easy to be conservative and ignore the patch, since -march=i686 should always work.
Just curious, what can go wrong ? Only if gcc has a bug when scheduling insns for P4, for example, or if gcc spits some special that does not work as supposed...
Signature · 4 lines
J.A. Magallon <[email protected]> \ Software is like sex: werewolf.able.es \ It's better when it's free Mandrake Linux release 9.2 (Cooker) for i586 Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))
Quoted 3 lines · J.A. Magallon
Just curious, what can go wrong ? Only if gcc has a bug when scheduling insns for P4, for example, or if gcc spits some special that does not work as supposed...
Well, any number of things, but I admit it's mostly just general paranoia / conservatism on my part.
In the past, on rare occasions, modification of the global CFLAGS or use of new gcc features has led to silent miscompilation of a few drivers.
Jeff
Quoth Jeff Garzik:
Quoted 6 lines
Quoted 5 lines · J.A. Magallon
ifdef
CONFIG_MPENTIUMIIIarch/i386/Makefile renamed from arch/i386/Makefile.orig +1
-1-CFLAGS += -march=i686 +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)endif
[...]
Quoted 3 lines
I haven't had any problems at all, but I'm curious if anyone has any negative feedback... It's rather easy to be conservative and ignore the patch, since -march=i686 should always work.
No problems over here. I've been running it since it was first submitted.
Kurt
Signature · 2 lines
If God had meant for us to be in the Army, we would have been born with green, baggy skin.