Skip to contentSkip to conversation

remove four superfluous BUG's in ReiserFS

PATCH New Adrian Bunk 1 participant 1 message Jul 16, 2003

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 remove four superfluous BUG's in ReiserFS

The trivial patch below by Randy Hron still applies agains 2.6.0-test1.

Please apply
Adrian

----- Forwarded message from [email protected] -----

Date: Tue, 15 Apr 2003 10:30:24 -0400
From: [email protected]
To: [email protected],
[email protected]
Subject: Re: BUGed to death

The patch below eliminates 4 BUG() calls that clearly cannot happen based on the context.

fs/reiserfs/hashes.c renamed from fs/reiserfs/hashes.c.orig +0 -13
@@ -90,10 +90,6 @@
 
 	if (len >= 12)
 	{
-	    	//assert(len < 16);
-		if (len >= 16)
-		    BUG();
-
 		a = (u32)msg[ 0]      |
 		    (u32)msg[ 1] << 8 |
 		    (u32)msg[ 2] << 16|

@@ -116,9 +112,6 @@
 	}
 	else if (len >= 8)
 	{
-	    	//assert(len < 12);
-		if (len >= 12)
-		    BUG();
 		a = (u32)msg[ 0]      |
 		    (u32)msg[ 1] << 8 |
 		    (u32)msg[ 2] << 16|

@@ -137,9 +130,6 @@
 	}
 	else if (len >= 4)
 	{
-	    	//assert(len < 8);
-		if (len >= 8)
-		    BUG();
 		a = (u32)msg[ 0]      |
 		    (u32)msg[ 1] << 8 |
 		    (u32)msg[ 2] << 16|

@@ -154,9 +144,6 @@
 	}
 	else
 	{
-	    	//assert(len < 4);
-		if (len >= 4)
-		    BUG();
 		a = b = c = d = pad;
 		for(i = 0; i < len; i++)
 		{
Signature · 10 lines
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----