Skip to contentSkip to conversation

- ac2-test1: Removing the obselete EXPORT_NO_SYMBOLS

PATCH In review Krishnakumar. R 2 participants 3 messages Jul 22, 2003

Subsystems (2)
Network drivers Sound
lore
Share & tools
lore

Krishnakumar. R

author
#0 lore raw

PATCH 1/1 - ac2-test1: Removing the obselete EXPORT_NO_SYMBOLS

Dear Alan,

The following patch would remove the obselete EXPORT_NO_SYMBOLS from some of the sources.

Quoted 1 line

From my understanding the EXPORT_NO_SYMBOLS is not needed any more as all the symbols, by default

are now kept away from being exported.

The patch is against the ac2 patched test1 kernel.

Hope it does not break anything !!

Regards
KK

===================================================
Result of ' cat patch_export_no_symbol-ac2-test1.patch | diffstat '

 arch/cris/arch-v10/drivers/pcf8563.c |    1 -
 drivers/net/meth.c       		      |    1 -
 sound/oss/harmony.c                      |    1 -
 sound/oss/swarm_cs4297a.c           |    1 -
 4 files changed, 4 deletions(-)

===================================================
The following is the patch:
===================================================

arch/cris/arch-v10/drivers/pcf8563.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c
@@ -282,6 +282,5 @@
 	return 0;
 }
 
-EXPORT_NO_SYMBOLS;
 module_init(pcf8563_init);
 module_exit(pcf8563_exit);
drivers/net/meth.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/drivers/net/meth.c linux-2.6.0-test1-ac2/drivers/net/meth.c
@@ -845,7 +845,6 @@
 		       result, meth_devs->name);
 	else device_present++;
 #ifndef METH_DEBUG
-	EXPORT_NO_SYMBOLS;
 #endif
 	
 	return device_present ? 0 : -ENODEV;
sound/oss/harmony.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c linux-2.6.0-test1-ac2/sound/oss/harmony.c
@@ -1285,7 +1285,6 @@
 	unregister_parisc_driver(&harmony_driver);
 }
 
-EXPORT_NO_SYMBOLS;
 
 MODULE_AUTHOR("Alex DeVries <[email protected]>");
 MODULE_DESCRIPTION("Harmony sound driver");
sound/oss/swarm_cs4297a.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c
@@ -90,7 +90,6 @@
 #include <asm/sibyte/64bit.h>
 
 struct cs4297a_state;
-EXPORT_NO_SYMBOLS;
 
 static void stop_dac(struct cs4297a_state *s);
 static void stop_adc(struct cs4297a_state *s);

-

#1 lore raw

drivers/net/meth.c line 848

Quoted 3 lines · Krishnakumar. R

#ifndef METH_DEBUG

drivers/net/meth.c +0 -1
-	EXPORT_NO_SYMBOLS;
 #endif

Why not just pull the whole #ifdef/#endif?

-Josh

Signature · 2 lines
Using words to describe magic is like using a screwdriver to cut roast beef.
		-- Tom Robbins
author
#2 lore raw

Please find the patch with the #ifndef removed.

Quoted 8 lines · Joshua Kwan

Review

Quoted 3 lines · Krishnakumar. R

#ifndef METH_DEBUG

(quoted diff) +0 -1
-	EXPORT_NO_SYMBOLS;
 #endif

Why not just pull the whole #ifdef/#endif?

-Josh

======================================================
Output of diffstat

arch/cris/arch-v10/drivers/pcf8563.c | 1 -

 drivers/net/meth.c                          |    3 ---
 sound/oss/harmony.c                     |    1 -
 sound/oss/swarm_cs4297a.c          |    1 -
 4 files changed, 6 deletions(-)

======================================================

arch/cris/arch-v10/drivers/pcf8563.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c
@@ -282,6 +282,5 @@
 	return 0;
 }
 
-EXPORT_NO_SYMBOLS;
 module_init(pcf8563_init);
 module_exit(pcf8563_exit);
drivers/net/meth.c +0 -3
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/drivers/net/meth.c linux-2.6.0-test1-ac2/drivers/net/meth.c
@@ -844,9 +844,6 @@
 		printk("meth: error %i registering device \"%s\"\n",
 		       result, meth_devs->name);
 	else device_present++;
-#ifndef METH_DEBUG
-	EXPORT_NO_SYMBOLS;
-#endif
 	
 	return device_present ? 0 : -ENODEV;
 }
sound/oss/harmony.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c linux-2.6.0-test1-ac2/sound/oss/harmony.c
@@ -1285,7 +1285,6 @@
 	unregister_parisc_driver(&harmony_driver);
 }
 
-EXPORT_NO_SYMBOLS;
 
 MODULE_AUTHOR("Alex DeVries <[email protected]>");
 MODULE_DESCRIPTION("Harmony sound driver");
sound/oss/swarm_cs4297a.c +0 -1
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c
@@ -90,7 +90,6 @@
 #include <asm/sibyte/64bit.h>
 
 struct cs4297a_state;
-EXPORT_NO_SYMBOLS;
 
 static void stop_dac(struct cs4297a_state *s);
 static void stop_adc(struct cs4297a_state *s);

-