Skip to contentSkip to conversation

Make yenta work

PM Pavel Machek 3 participants 3 messages Jul 26, 2003 – Aug 5, 2003 Pcmcia

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

This makes yenta work, and its really trivial...
Pavel

drivers/pcmcia/yenta_socket.c +4 -1
Index: linux/drivers/pcmcia/yenta_socket.c
===================================================================
@@ -899,7 +899,10 @@
 
 static int yenta_dev_suspend (struct pci_dev *dev, u32 state)
 {
-	return pcmcia_socket_dev_suspend(&dev->dev, state, 0);
+	/* FIXME: We should really let devices to act on *all* levels :-(.
+	   If you put something else than SUSPEND_SAVE_STATE,
+	   pcmcia_socket_dev_suspend() will simply do nothing due to its check. */
+	return pcmcia_socket_dev_suspend(&dev->dev, state, SUSPEND_SAVE_STATE);
 }
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw
Quoted 9 lines

This makes yenta work, and its really trivial...
Pavel

Index: linux/drivers/pcmcia/yenta_socket.c
===================================================================

drivers/pcmcia/yenta_socket.c line 906

Quoted 9 lines
drivers/pcmcia/yenta_socket.c +4 -1
@@ -899,7 +899,10 @@
 
 static int yenta_dev_suspend (struct pci_dev *dev, u32 state)
 {
-	return pcmcia_socket_dev_suspend(&dev->dev, state, 0);
+	/* FIXME: We should really let devices to act on *all* levels :-(.
+	   If you put something else than SUSPEND_SAVE_STATE,
+	   pcmcia_socket_dev_suspend() will simply do nothing due to its check. */
+	return pcmcia_socket_dev_suspend(&dev->dev, state, SUSPEND_SAVE_STATE);
 }

I believe I saw a patch from Russell get in over the weekend that did this, right?

-pat

#2 lore raw
Quoted 2 lines · Patrick Mochel

I believe I saw a patch from Russell get in over the weekend that did this, right?

Correct.

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html