Skip to contentSkip to conversation

Qla1280 update to 3.23.24

DISCUSSION Jeff Garzik 2 participants 2 messages Aug 18, 2003 – Aug 19, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jeff Garzik

author
#1 lore raw

drivers/scsi/qla1280.h line 1118

Quoted 12 lines · Linux Kernel Mailing List

diff -Nru a/drivers/scsi/qla1280.h b/drivers/scsi/qla1280.h

drivers/scsi/qla1280.h +4 -0
@@ -1111,7 +1111,11 @@
 /*
  *  Linux - SCSI Driver Interface Function Prototypes.
  */
+#if LINUX_VERSION_CODE < 0x020600
 int qla1280_proc_info(char *, char **, off_t, int, int, int);
+#else
+int qla1280_proc_info(struct Scsi_Host *, char *, char **, off_t, int, int);
+#endif

Since we have people _constantly_ screwing this up (but of course, never you, Jes :)), please use the KERNEL_VERSION() macro instead of open-coding the kernel version you are testing. It makes these tests not only harder to screw up, but easier to read, too.

Jeff

#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jeff" == Jeff Garzik <[email protected]> writes:

Jeff> Since we have people _constantly_ screwing this up (but of Jeff> course, never you, Jes :)), please use the KERNEL_VERSION() Jeff> macro instead of open-coding the kernel version you are testing. Jeff> It makes these tests not only harder to screw up, but easier to Jeff> read, too.

Thats why I used the hex-value and not decimal. Sorry, maybe I am old fashioned but I always disliked that macro and the hex values are really easy to read which is why I decided to stick to that.

Cheers,
Jes