Skip to contentSkip to conversation

remove ipt_unclean match from 2.6.x

PATCH Applied Harald Welte 2 participants 2 messages Aug 23, 2003 – Aug 24, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove ipt_unclean match from 2.6.x

Hi Dave!

The following (trivial) patch removes the unclean match from the 2.6.0-test4 kernel.

We have decided to remove the unclean match, since it is considered a potentially dangerous function of the current iptables code.

The match is used by lots of users who don't really undestand what kind of danger they are imposing on the future-compatibility of their networks. (just think of the ECN issue resulting from this kind of filtering)

We'd rather keep it in patch-o-matic, where lots of other modules that are only useful in experimental scenarios are kept.

Now that we don't have to keep it for compatibility reasons, we'd like to remove it before 2.6.0 final is released.

Please apply, thanks.

net/ipv4/netfilter/Kconfig +0 -10
diff -Nru linux-2.6.0-test4-queue/net/ipv4/netfilter/Kconfig linux-2.6.0-test4-unclean/net/ipv4/netfilter/Kconfig
@@ -271,16 +271,6 @@
 	  If you want to compile it as a module, say M here and read
 	  Documentation/modules.txt.  If unsure, say `N'.
 
-config IP_NF_MATCH_UNCLEAN
-	tristate "Unclean match support (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && IP_NF_IPTABLES
-	help
-	  Unclean packet matching matches any strange or invalid packets, by
-	  looking at a series of fields in the IP, TCP, UDP and ICMP headers.
-
-	  If you want to compile it as a module, say M here and read
-	  <file:Documentation/modules.txt>.  If unsure, say `N'.
-
 config IP_NF_MATCH_OWNER
 	tristate "Owner match support (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && IP_NF_IPTABLES
net/ipv4/netfilter/Makefile +0 -1
diff -Nru linux-2.6.0-test4-queue/net/ipv4/netfilter/Makefile linux-2.6.0-test4-unclean/net/ipv4/netfilter/Makefile
@@ -61,7 +61,6 @@
 obj-$(CONFIG_IP_NF_MATCH_TTL) += ipt_ttl.o
 obj-$(CONFIG_IP_NF_MATCH_STATE) += ipt_state.o
 obj-$(CONFIG_IP_NF_MATCH_CONNTRACK) += ipt_conntrack.o
-obj-$(CONFIG_IP_NF_MATCH_UNCLEAN) += ipt_unclean.o
 obj-$(CONFIG_IP_NF_MATCH_TCPMSS) += ipt_tcpmss.o
 
 obj-$(CONFIG_IP_NF_MATCH_PHYSDEV) += ipt_physdev.o
net/ipv4/netfilter/ipt_unclean.c +0 -610

610 lines not on this page · raw message

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie
#1 lore raw
Quoted 2 lines · On Sat, 23 Aug 2003 23:19:26 +0200 Harald Welte <[email protected]> wrote:

We have decided to remove the unclean match, since it is considered a potentially dangerous function of the current iptables code.

Applied, thanks.