Skip to contentSkip to conversation

Firmware loading depends on hotplug support

PATCH Tom Rini 2 participants 2 messages Sep 1, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tom Rini

author
#1 lore raw
Quoted 21 lines · On Fri, Aug 15, 2003 at 04:27:11PM +0000, [email protected] wrote:

ChangeSet 1.1065.2.3, 2003/08/15 18:27:11+02:00, [email protected]

[PATCH] Firmware loading depends on hotplug support

This patch makes the firmware loading support only selectable if the hotplug support is also enabled.

# This patch includes the following deltas:
# ChangeSet 1.1065.2.2 -> 1.1065.2.3
# lib/Config.in 1.4 -> 1.5
#

 Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Nru a/lib/Config.in b/lib/Config.in

lib/Config.in line 47

Quoted 8 lines
lib/Config.in +2 -1
@@ -41,7 +41,8 @@
   fi
 fi
 
-if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+if [ "$CONFIG_EXPERIMENTAL" = "y" -a \
+     "$CONFIG_HOTPLUG" = "y" ]; then
    tristate 'Hotplug firmware loading support (EXPERIMENTAL)' CONFIG_FW_LOADER
 fi

Is this really a good idea, given that USB devices may be hot-plugged, without CONFIG_HOTPLUG set (drivers are compiled in, for example) ?

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#2 lore raw

Hi Tom,

Quoted 22 lines
Quoted 22 lines

[PATCH] Firmware loading depends on hotplug support

This patch makes the firmware loading support only selectable if the hotplug support is also enabled.

# This patch includes the following deltas:
# ChangeSet 1.1065.2.2 -> 1.1065.2.3
# lib/Config.in 1.4 -> 1.5
#

 Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Nru a/lib/Config.in b/lib/Config.in

lib/Config.in +0 -0
@@ -41,7 +41,8 @@
   fi
 fi
 
Quoted 8 lines

lib/Config.in line 47

Quoted 5 lines
lib/Config.in +2 -1
-if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+if [ "$CONFIG_EXPERIMENTAL" = "y" -a \
+     "$CONFIG_HOTPLUG" = "y" ]; then
    tristate 'Hotplug firmware loading support (EXPERIMENTAL)' CONFIG_FW_LOADER
 fi

Is this really a good idea, given that USB devices may be hot-plugged, without CONFIG_HOTPLUG set (drivers are compiled in, for example) ?

this option is only provided for drivers outside the kernel. If a driver inside the kernel needs it, it is selected automaticly like the CRC32 routines.

If you disable hotplug support the request_firmware() routine will return an error and this must be handled by the driver.

Regards

Marcel