Skip to contentSkip to conversation

2.4.22, USB visor module crashing on HotSync.

OOPS Greg KH 2 participants 2 messages Sep 5, 2003 – Sep 24, 2003

Subsystems (2)
lore
Share & tools
lore

Greg KH

author
#0 lore raw
Quoted 12 lines · Ingo Oeser

Hi Greg,

there seems to be a problem with the visor module and usb_serial.

Please look at __serial_close() and usb_disconnect() calling it in line 1406 vs. line 1408. I would suggest removing 1408 or folding it into __serial_close().

Formal Bug-Reporting follows:

[1.] One line summary of the problem:

Quoted 7 lines

USB visor module and usb_serial crashing on HotSync in usb_disconnect

[2.] Full description of the problem/report:

usb_disconnect calls __serial_close() which sets the tty = NULL and afterwards trys to set tty->private_data = NULL which will crash

Nice, someone else reported this yesterday for the ftdi_sio driver.

Can you test the patch below and let me know if this fixes it?

thanks,

greg k-h

drivers/usb/serial/usbserial.c +6 -6
@@ -556,7 +556,10 @@
 		else
 			generic_close(port, filp);
 		port->open_count = 0;
-		port->tty = NULL;
+		if (port->tty) {
+			port->tty->driver_data = NULL;
+			port->tty = NULL;
+		}
 	}
 
 	if (port->serial->type->owner)
@@ -1401,12 +1404,9 @@
 		for (i = 0; i < serial->num_ports; ++i) {
 			port = &serial->port[i];
 			down (&port->sem);
-			if (port->tty != NULL) {
-				while (port->open_count > 0) {
+			if (port->tty != NULL)
+				while (port->open_count > 0)
 					__serial_close(port, NULL);
-				}
-				port->tty->driver_data = NULL;
-			}
 			up (&port->sem);
 		}
 
#1 lore raw

Hi Greg,
hi lkml,

Quoted 3 lines · you

Nice, someone else reported this yesterday for the ftdi_sio driver.

Can you test the patch below and let me know if this fixes it?

It fixes it. Now it doesn't oops anymore.

Regards

Ingo Oeser