Skip to contentSkip to conversation

ide-io.c, kernel 2.4.22 Fix for IO stats in /proc/partitions, was Re: sard/iostat disk I/O statistics/accounting for 2.5.8-pre3

PATCH Stephen C. Tweedie 1 participant 1 message Sep 24, 2003 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi,

Quoted 2 lines · Chad Talbott

Here's the one that I compiled and tested. It makes /proc/partitions report correctly.

Looks OK, but I'd defer to an IDE expert on the question of whether this is the best fix or not.

Basically, you need to pair accounting start points with accounting end points. This patch removes the end point from the IDE special-command postprocessing, but only by manually replacing end_that_request_last() with a variant which doesn't do accounting.

I'd really rather see a patch which accounted for the start of the special command in the first place (via "req_new_io()" when the special request is first queued), as I suspect that might be a more robust way of doing things. But as I said, it would take somebody more familiar with the IDE code to know whether that's really going to be better or not.

Cheers,
Stephen